vdk-plugins: introduced vdk-audit plugin #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visibility into the actions provides opportunities for test frameworks, logging frameworks, and security tools to monitor and optionally limit actions taken by the runtime. This plugin provides the ability to audit and potentially limit user actions. In order to have a better understanding of what precisely the job does, we will log not permitted job actions. It is based on the Python Audit Hook - https://peps.python.org/pep-0578/. Testing Done: local job execution and unit tests Signed-off-by: Miroslav Ivanov miroslavi@vmware.com
Visibility into the actions provides opportunities for test frameworks, logging frameworks, and security tools to monitor and optionally limit actions taken by the runtime. This plugin provides the ability to audit and potentially limit user actions. In order to have a better understanding of what precisely the job does, we will log not permitted job actions. It is based on the Python Audit Hook - https://peps.python.org/pep-0578/. Testing Done: local job execution and unit tests Signed-off-by: Miroslav Ivanov miroslavi@vmware.com
Visibility into the actions provides opportunities for test frameworks, logging frameworks, and security tools to monitor and optionally limit actions taken by the runtime. This plugin provides the ability to audit and potentially limit user actions. In order to have a better understanding of what precisely the job does, we will log not permitted job actions. It is based on the Python Audit Hook - https://peps.python.org/pep-0578/. Testing Done: local job execution and unit tests Signed-off-by: Miroslav Ivanov miroslavi@vmware.com
Visibility into the actions provides opportunities for test frameworks, logging frameworks, and security tools to monitor and optionally limit actions taken by the runtime. This plugin provides the ability to audit and potentially limit user actions. In order to have a better understanding of what precisely the job does, we will log not permitted job actions. It is based on the Python Audit Hook - https://peps.python.org/pep-0578/. Testing Done: local job execution and unit tests Signed-off-by: Miroslav Ivanov miroslavi@vmware.com
|
Let's name the plugin And while I understand that this is referring to PEP 578 audit hooks, I still think vdk-audit is clear enough and I will be grateful if you change it |
antoniivanov
requested changes
Oct 5, 2022
projects/vdk-plugins/vdk-audit-hook/src/vdk/plugin/audit_hook/audit_hook_config.py
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-audit-hook/src/vdk/plugin/audit_hook/audit_hook_plugin.py
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-audit-hook/tests/functional/test_audit_hook_plugin.py
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-audit-hook/tests/functional/test_audit_hook_plugin.py
Outdated
Show resolved
Hide resolved
…e/versatile-data-kit into person/miroslavi/audit-hook-plugin
antoniivanov
reviewed
Oct 7, 2022
projects/vdk-plugins/vdk-audit/src/vdk/plugin/audit/audit_config.py
Outdated
Show resolved
Hide resolved
murphp15
approved these changes
Oct 7, 2022
projects/vdk-plugins/vdk-audit/src/vdk/plugin/audit/audit_plugin.py
Outdated
Show resolved
Hide resolved
mivanov1988
changed the title
projects/vdk-plugins/vdk-audit/src/vdk/plugin/audit/audit_plugin.py
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-audit/src/vdk/plugin/audit/audit_plugin.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the VDK users have the ability to execute any kind of system commands through the data job. This increases the risk to the system as data jobs contain arbitrary user code.
Visibility into the actions provides opportunities for test frameworks, logging frameworks, and security tools to monitor and optionally limit actions taken by the runtime.
This plugin provides the ability to audit and potentially limit user actions. In order to reduce the attack surface, we will limit the user actions related to the interaction with the system like os commands (e.g.
os.system("ls")). Also, to have a better understanding of what precisely the job does, we will log not permitted job actions. The plugin is based on the Python Audit Hook and you can find more information here - https://peps.python.org/pep-0578/.Testing Done: local job execution and unit tests
Signed-off-by: Miroslav Ivanov miroslavi@vmware.com