vdk-core: platform error no longer logged when skipping execution steps #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrMoZ1
changed the title
antoniivanov
reviewed
Oct 5, 2022
projects/vdk-core/src/vdk/internal/builtin_plugins/run/file_based_step.py
Outdated
Show resolved
Hide resolved
antoniivanov
approved these changes
Oct 5, 2022
gageorgiev
approved these changes
Oct 6, 2022
added 3 commits
October 6, 2022 12:42
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
mrMoZ1
force-pushed
the
person/mzhivkov/job-cancellation-fix
branch
from
dec0d84
to
9683600
Compare
added 2 commits
October 6, 2022 13:01
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what: Changed the call to the errors.log_and_rethrow method for
a simple log statement and re-raising the exception when the
CancelRemainingSteps exception is raised.
why: Users reading the logs might be confused by the statement,
which assumes a platform error occurred. Recently reverted changes
to the error handling also made jobs using this feature fail with
platform errors since the log_and_rethrow method tripped the
internal logic and made the writer plugin write a platform error
termination message.
testing: Expanded unit test to cover the termination plugin when using
the skip_remaining_steps() functionality.