[vdk-plugins] vdk-ingest-http: Move data conversion above size calc #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the memory size of the payload to be ingested is calculated before it is converted to string. This is fine for most cases, however, it gets a bit tricky for more complex objects, due to how memory size is calculated (see https://stackoverflow.com/questions/63204377/memory-size-of-list-python for reference). This change moves the conversion of the payload to string before the memory size is calculated, so we avoid posibility to return misleading IngestionResult data. Testing Done: Cosmetic change, all tests pass. Signed-off-by: Andon Andonov <andonova@vmware.com>
doks5
force-pushed
the
person/andonova/ingestion-payload-size
branch
from
bc3ceda
to
bb19205
Compare
dakodakov
approved these changes
Oct 19, 2022
antoniivanov
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the memory size of the payload to be ingested is calculated before it is converted to string. This is fine for most cases, however, it gets a bit tricky for more complex objects, due to how memory size is calculated (see https://stackoverflow.com/questions/63204377/memory-size-of-list-python for reference).
This change moves the conversion of the payload to string before the memory size is calculated, so we avoid posibility to return misleading IngestionResult data.
Testing Done: Cosmetic change, all tests pass.
Signed-off-by: Andon Andonov andonova@vmware.com