control-service: Dynamic python site-packages directory detection #1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The python site-packages directory is currently hardcoded in the data job container command. However, this works only for data jobs based on Python 3.7. This change aims to make the data job cronjob template agnostic for the python version by replacing the hardcoded python site-packages directory with a python command that returns it. Tested locally against the kind cluster. Signed-off-by: Miroslav Ivanov miroslavi@vmware.com
antoniivanov
approved these changes
Oct 19, 2022
dakodakov
approved these changes
Oct 19, 2022
mivanov1988
deleted the
person/miroslavi/dynamic-python-site-packages-directory-detection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The python site-packages directory is currently hardcoded in the data job container command. However,
this works only for data jobs based on Python 3.7.
This change aims to make the data job cronjob template agnostic for the python version by replacing the hardcoded python site-packages directory with a python command that returns it.
Tested locally against kind cluster.
Signed-off-by: Miroslav Ivanov miroslavi@vmware.com