control-service: latest graphql version #1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: murphp15 <murphp15@tcd.ie>
murphp15
changed the title
antoniivanov
reviewed
Dec 1, 2022
projects/control-service/projects/versions-of-external-dependencies.gradle
Show resolved
Hide resolved
gageorgiev
approved these changes
Dec 1, 2022
antoniivanov
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Dependabot is trying to upgrade to the latest version of spring (#1305) but it is running in to compile issues.
These compile issues are related to us using very old graphql libraries.
What
In this PR I upgrade the very old graphql libraries so that the spring upgrade can happen in the other PR.
There is one method declaration change in the newer functions so I had to make that change in the codebase too.
How has this been tested
Unit and integration tests.