control-service: run release test on dependency version change #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of change in versions-of-external-dependencies.gradle we are directly making a new release without triggering release acceptance test which may result in broken release. It's better to make sure the release is tested. Also removed job-builder changes from trigger deployment and release test for now as generally default job-builder version is pinned so when changed it would trigger new test. We need to devise a way to test all differnt job-builders anyhow. Finally refactored slighlty the yaml anchors to re-use previously defined ones. Testing Done: this PR
for more information, see https://pre-commit.ci
murphp15
approved these changes
Dec 3, 2022
doks5
approved these changes
Dec 4, 2022
Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
murphp15
reviewed
Dec 5, 2022
murphp15
reviewed
Dec 5, 2022
antoniivanov
force-pushed
the
person/aivanov/control-service-ci
branch
2 times, most recently
from
9442811
to
57d98d5
Compare
Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
antoniivanov
force-pushed
the
person/aivanov/control-service-ci
branch
from
57d98d5
to
e093561
Compare
murphp15
reviewed
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of change in versions-of-external-dependencies.gradle we are directly making a new release without triggering release acceptance test which may result in broken release. It's better to make sure the release is tested.
Also removed job-builder changes from trigger deployment and release test for now as generally default job-builder version is pinned so when changed it would trigger new test. We need to devise a way to test all differnt job-builders anyhow.
Finally refactored slighlty the yaml anchors to re-use previously defined ones.
Testing Done: this PR