vdk-core: get_managed_connection should return opened connection #1410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murphp15
approved these changes
Dec 5, 2022
antoniivanov
force-pushed
the
person/aivanov/managed-conn
branch
from
5bc2252
to
a7d22c5
Compare
ivakoleva
requested changes
Dec 6, 2022
projects/vdk-core/src/vdk/internal/builtin_plugins/run/job_input.py
Outdated
Show resolved
Hide resolved
ivakoleva
requested changes
Dec 6, 2022
projects/vdk-core/src/vdk/internal/builtin_plugins/run/job_input.py
Outdated
Show resolved
Hide resolved
antoniivanov
force-pushed
the
person/aivanov/managed-conn
branch
from
a7d22c5
to
d1b64f4
Compare
ivakoleva
requested changes
Dec 6, 2022
projects/vdk-core/src/vdk/internal/builtin_plugins/run/job_input.py
Outdated
Show resolved
Hide resolved
projects/vdk-core/src/vdk/internal/builtin_plugins/connection/managed_connection_base.py
Show resolved
Hide resolved
projects/vdk-core/src/vdk/internal/builtin_plugins/connection/managed_connection_base.py
Outdated
Show resolved
Hide resolved
projects/vdk-core/src/vdk/internal/builtin_plugins/connection/impl/router.py
Show resolved
Hide resolved
projects/vdk-core/src/vdk/internal/builtin_plugins/connection/impl/router.py
Outdated
Show resolved
Hide resolved
projects/vdk-core/src/vdk/internal/builtin_plugins/connection/impl/router.py
Outdated
Show resolved
Hide resolved
|
Thanks for the feedback Iva. I will address it next week at some point (after I am back). |
ivakoleva
approved these changes
Dec 12, 2022
projects/vdk-core/src/vdk/internal/builtin_plugins/connection/impl/router.py
Show resolved
Hide resolved
projects/vdk-core/src/vdk/internal/builtin_plugins/connection/impl/router.py
Outdated
Show resolved
Hide resolved
projects/vdk-core/tests/functional/run/jobs/pandas-job/10_pandas_step.py
Show resolved
Hide resolved
Currently job_input.get_managed_connection() return the current managed connection which may not be opened if it's called for a first time. THis may lead to subtle bugs e.g ``` pandas.to_sql(sql, con = job_input.get_managed_connection()) ``` will return error if job_input.execute_query has not be run before. But will succeed if it's not . That's clearly error prone and also it's unnecessary to force users to called job_input.get_managed_connection().connect() explicitly). Testing Done: functional test Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
to be squashed Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
antoniivanov
force-pushed
the
person/aivanov/managed-conn
branch
from
50f6f26
to
96d7edf
Compare
Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently job_input.get_managed_connection() return the current managed connection which may not be opened if it's called for a first time. THis may lead to subtle bugs e.g
will return error if job_input.execute_query has not be run before. But will succeed if it's not . That's clearly error prone and also it's unnecessary to force users to called
job_input.get_managed_connection().connect() explicitly).
Testing Done: functional test
Signed-off-by: Antoni Ivanov aivanov@vmware.com