vdk-jupyter: notebook-plugin #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
antoniivanov
reviewed
Dec 6, 2022
...notebook/tests/jobs/rest-api-job-fail-syntax-error/.ipynb_checkpoints/steps-checkpoint.ipynb
Outdated
Show resolved
Hide resolved
antoniivanov
reviewed
Dec 6, 2022
projects/vdk-plugins/vdk-notebook/tests/jobs/rest-api-job-fail-syntax-error/config.ini
Outdated
Show resolved
Hide resolved
…eeded information from config.ini files
ivakoleva
reviewed
Dec 6, 2022
projects/vdk-plugins/vdk-notebook/src/vdk/plugin/notebook/notebook_plugin.py
Show resolved
Hide resolved
projects/vdk-plugins/vdk-notebook/src/vdk/plugin/notebook/notebook_plugin.py
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-notebook/src/vdk/plugin/notebook/notebook_plugin.py
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-notebook/src/vdk/plugin/notebook/notebook_plugin.py
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-notebook/src/vdk/plugin/notebook/notebook_reader.py
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-notebook/src/vdk/plugin/notebook/notebook_step.py
Outdated
Show resolved
Hide resolved
ivakoleva
approved these changes
Dec 8, 2022
projects/vdk-plugins/vdk-notebook/src/vdk/plugin/notebook/notebook.py
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-notebook/src/vdk/plugin/notebook/notebook.py
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-notebook/src/vdk/plugin/notebook/notebook.py
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-notebook/src/vdk/plugin/notebook/notebook.py
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-notebook/tests/jobs/rest-api-job-code-error/steps.ipynb
Show resolved
Hide resolved
ivakoleva
approved these changes
Dec 8, 2022
projects/vdk-plugins/vdk-notebook/tests/jobs/rest-api-job-code-error/steps.ipynb
Show resolved
Hide resolved
murphp15
reviewed
Dec 9, 2022
murphp15
reviewed
Dec 9, 2022
projects/vdk-plugins/vdk-notebook/src/vdk/plugin/notebook/notebook_based_step.py
Show resolved
Hide resolved
murphp15
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Adding the hook for initialising a job which works with .ipynb files and the helper classes.
Why:
It is linked to the issue
Tests: provided unit tests
Signed-off-by: Duygu Hasan hduygu@vmware.com