vdk-jupyter: changes on diagrams and definition in notebook-plugin section in VEP #1427
Conversation
| As it can be seen from the below diagram the plugin will consist of a new hook and a few new classes. | ||
|
|
||
|  | ||
|  |
There was a problem hiding this comment.
How are those pictures produced? I strongly encourage including the "source" so that someone else can edit them if they find a mistake. Or maybe if they want to re-use them and extend them for another VEP for example.
There was a problem hiding this comment.
Sadly, the tool I am using does not allow such "sharing". But I can put its link, of course. If you have any recommendations for another tool which can provide such sharing of the source would be amazing :)
There was a problem hiding this comment.
What tool are you using ? What is the link? If I can reproduce it from that link and edit it. This is fine.
There was a problem hiding this comment.
I use the free version of https://lucid.app . But you cannot reproduce it.
There was a problem hiding this comment.
You can publish it (There's publish button) and include the link as a comment <!-- link --> in the VEP next to the image.
There was a problem hiding this comment.
Yes, but I cannot share everything since there is a limit of 3 documents for the free version. I currently have only one of them as lucid document, others are deleted after work and only the images are saved.
There was a problem hiding this comment.
I can still link the one I have but I don't think it is ok for long term use since there can be added more images.
| @@ -27,6 +27,7 @@ useful for a wide audience. | |||
|
|
|||
| * VDK: https://github.com/vmware/versatile-data-kit/wiki/dictionary#vdk | |||
| * Notebook: A .ipynb file. | |||
| * Notebook cell: a multiline text input field | |||
There was a problem hiding this comment.
For external terms. Link to the defintion. This seems to have come from https://jupyter-notebook.readthedocs.io/en/stable/notebook.html#structure-of-a-notebook-document
So add a link
Notebook cell: a multiline text input field ([defined in details here](https://jupyter-notebook.readthedocs.io/en/stable/notebook.html#structure-of-a-notebook-document))
There was a problem hiding this comment.
I will add it with the next change on VEP
There was a problem hiding this comment.
I see it's merged. I made some small comments but looks good to me.
I am interested in finding out what is the development experience though ?
So I open a new notebook and start writing - SQL cell and execute, then python cell, execute it, then vdk run cell . It should keep the state of the job run in memory. Would this work after installing the plugin
Or is that part of the responsibility of another component?
These changes are required because of some changes of the structure of the notebook-plugin during the development and to provide a better definition of what a NotebookStep defines.
Signed-off-by: Duygu Hasan hduygu@vmware.com