vdk-jobs-trobleshooting: Introduce plugin API and configuration #1447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...gins/vdk-jobs-troubleshooting/src/vdk/plugin/jobs_troubleshoot/troubleshoot_configuration.py
Show resolved
Hide resolved
...lugins/vdk-jobs-troubleshooting/src/vdk/plugin/jobs_troubleshoot/api/troubleshoot_utility.py
Show resolved
Hide resolved
...gins/vdk-jobs-troubleshooting/src/vdk/plugin/jobs_troubleshoot/troubleshoot_configuration.py
Outdated
Show resolved
Hide resolved
antoniivanov
approved these changes
Dec 15, 2022
...lugins/vdk-jobs-troubleshooting/src/vdk/plugin/jobs_troubleshoot/api/troubleshoot_utility.py
Show resolved
Hide resolved
doks5
force-pushed
the
person/andonova/vdk-job-troubleshooting-plugin
branch
from
d8e86c4
to
1ea1e15
Compare
...lugins/vdk-jobs-troubleshooting/src/vdk/plugin/jobs_troubleshoot/api/troubleshoot_utility.py
Show resolved
Hide resolved
...lugins/vdk-jobs-troubleshooting/src/vdk/plugin/jobs_troubleshoot/api/troubleshoot_utility.py
Show resolved
Hide resolved
doks5
force-pushed
the
person/andonova/vdk-job-troubleshooting-plugin
branch
from
1ea1e15
to
27eef67
Compare
ivakoleva
approved these changes
Dec 16, 2022
...lugins/vdk-jobs-troubleshooting/src/vdk/plugin/jobs_troubleshoot/api/troubleshoot_utility.py
Show resolved
Hide resolved
...lugins/vdk-jobs-troubleshooting/src/vdk/plugin/jobs_troubleshoot/api/troubleshoot_utility.py
Outdated
Show resolved
Hide resolved
...lugins/vdk-jobs-troubleshooting/src/vdk/plugin/jobs_troubleshoot/api/troubleshoot_utility.py
Show resolved
Hide resolved
...lugins/vdk-jobs-troubleshooting/src/vdk/plugin/jobs_troubleshoot/api/troubleshoot_utility.py
Show resolved
Hide resolved
dakodakov
approved these changes
Dec 16, 2022
This change introduces the base utility class which is to be used by all troubleshooting utilities. Additionally, the plugin configuration is moved to a separate method to be easier to extend. Testing Done: Documentation change. Signed-off-by: Andon Andonov <andonova@vmware.com>
doks5
force-pushed
the
person/andonova/vdk-job-troubleshooting-plugin
branch
from
27eef67
to
b0e7ff6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces the base utility class which is to be used by all troubleshooting utilities.
Additionally, the plugin configuration is moved to a separate method to be easier to extend.
Testing Done: Documentation change.
Signed-off-by: Andon Andonov andonova@vmware.com