vdk-jupyter: run VDK job #1454
Merged
vdk-jupyter: run VDK job #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
murphp15
reviewed
Dec 16, 2022
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/schema/plugin.json
Show resolved
Hide resolved
murphp15
reviewed
Dec 16, 2022
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/schema/plugin.json
Show resolved
Hide resolved
murphp15
reviewed
Dec 18, 2022
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/serverRequests.ts
Show resolved
Hide resolved
murphp15
reviewed
Dec 18, 2022
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/serverRequests.ts
Show resolved
Hide resolved
murphp15
reviewed
Dec 18, 2022
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/serverRequests.ts
Show resolved
Hide resolved
murphp15
reviewed
Dec 18, 2022
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/commandsAndMenu.tsx
Show resolved
Hide resolved
murphp15
reviewed
Dec 18, 2022
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/components/RunJob.tsx
Outdated
Show resolved
Hide resolved
murphp15
reviewed
Dec 18, 2022
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/components/RunJob.tsx
Show resolved
Hide resolved
ivakoleva
approved these changes
Dec 19, 2022
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/commandsAndMenu.tsx
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/serverRequests.ts
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/serverRequests.ts
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/components/RunJob.tsx
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/components/RunJob.tsx
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/vdk-jupyterlab-extension/vdk.py
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/vdk-jupyterlab-extension/handlers.py
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/style/base.css
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/vdk-jupyterlab-extension/vdk.py
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/components/RunJob.tsx
Show resolved
Hide resolved
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
antoniivanov
approved these changes
Dec 22, 2022
| process = subprocess.Popen( | ||
| cmd, stdout=log_file, stderr=log_file, env=os.environ.copy() | ||
| ) | ||
| subprocess.check_output(["/bin/ls", "-l"]) |
There was a problem hiding this comment.
This was just for testing purposes I assume. But it should not have been merged.
There was a problem hiding this comment.
Shall I remove it now?
There was a problem hiding this comment.
Here is a good suggestion https://stackoverflow.com/questions/21009416/python-subprocess-security
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a new feature to the Jupyterlab extension. It allows users to run VDK job from the Jupyter UI.
More information on how to work with the command can be found in UX Flows section of the Jupyter VEP.
Also it solves the issue since the connection is working now.
Signed-off-by: Duygu Hasan hduygu@vmware.com