vdk-jobs-troubleshooting: Add thread-dump utility #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doks5
force-pushed
the
person/andonova/vdk-job-troubleshooting-plugin
branch
from
3d7afdc
to
165377f
Compare
This change adds the implementation of a thread-dump utility to the vdk-jobs-troubleshooting plugin. The utility uses an http server, through which an administrator is able to force a stacktrace dump of all threads used by the python process of the data job. The server is bound to a port on the localhost, so to get the stacktrace, one needs to be attached to the data job pod. Testing Done: Added unit tests for the utility registry, and tested the plugin itself locally by running a simple data job and examining the execution logs. Signed-off-by: Andon Andonov <andonova@vmware.com>
doks5
force-pushed
the
person/andonova/vdk-job-troubleshooting-plugin
branch
from
165377f
to
21bc48f
Compare
There was a problem hiding this comment.
Please write functional test . The cookiecutter provides template - https://github.com/tozka/cookiecutter-vdk-plugin/blob/main/vdk-%7B%7Bcookiecutter.plugin_name%7D%7D/tests/test_plugin.py
The functional tests are very powerful mechanism to make sure the functionality we write really works as expected - as they are really "data jobs" that use that functionality.
...roubleshooting/src/vdk/plugin/jobs_troubleshoot/troubleshoot_utilities/healthcheck_server.py
Show resolved
Hide resolved
...-jobs-troubleshooting/src/vdk/plugin/jobs_troubleshoot/troubleshoot_utilities/thread_dump.py
Show resolved
Hide resolved
...lugins/vdk-jobs-troubleshooting/src/vdk/plugin/jobs_troubleshoot/jobs_troubleshoot_plugin.py
Outdated
Show resolved
Hide resolved
murphp15
reviewed
Dec 19, 2022
...lugins/vdk-jobs-troubleshooting/src/vdk/plugin/jobs_troubleshoot/jobs_troubleshoot_plugin.py
Outdated
Show resolved
Hide resolved
murphp15
reviewed
Dec 19, 2022
...-jobs-troubleshooting/src/vdk/plugin/jobs_troubleshoot/troubleshoot_utilities/thread_dump.py
Show resolved
Hide resolved
Add functional test. Minor code refactoring. Signed-off-by: Dako Dakov <ddakov@vmware.com>
I just added a functional test. |
Add documentation. Remove redundant Optional type. Signed-off-by: Dako Dakov <ddakov@vmware.com>
Remove unused import. Signed-off-by: Dako Dakov <ddakov@vmware.com>
Remove unused import. Signed-off-by: Dako Dakov <ddakov@vmware.com>
murphp15
reviewed
Jan 4, 2023
...roubleshooting/src/vdk/plugin/jobs_troubleshoot/troubleshoot_utilities/healthcheck_server.py
Outdated
Show resolved
Hide resolved
murphp15
reviewed
Jan 4, 2023
...roubleshooting/src/vdk/plugin/jobs_troubleshoot/troubleshoot_utilities/healthcheck_server.py
Outdated
Show resolved
Hide resolved
|
I think that there should be docs describing how to use it. |
murphp15
approved these changes
Jan 4, 2023
Remove redundancies. Signed-off-by: Dako Dakov <ddakov@vmware.com>
|
I can see it's not release yet (the release job did not trigger ) . It's commented out but I think you can release it: |
duyguHsnHsn
pushed a commit
that referenced
this pull request
Jan 6, 2023
* vdk-jobs-troubleshooting: Add thread-dump utility This change adds the implementation of a thread-dump utility to the vdk-jobs-troubleshooting plugin. The utility uses an http server, through which an administrator is able to force a stacktrace dump of all threads used by the python process of the data job. The server is bound to a port on the localhost, so to get the stacktrace, one needs to be attached to the data job pod. Testing Done: Added unit tests for the utility registry, and tested the plugin itself locally by running a simple data job and examining the execution logs. Signed-off-by: Andon Andonov <andonova@vmware.com> * vdk-jobs-troubleshooting: Add functional test Add functional test. Minor code refactoring. Signed-off-by: Dako Dakov <ddakov@vmware.com> * vdk-jobs-troubleshooting: Address review feedback Add documentation. Remove redundant Optional type. Signed-off-by: Dako Dakov <ddakov@vmware.com> * vdk-jobs-troubleshooting: remove unused import Remove unused import. Signed-off-by: Dako Dakov <ddakov@vmware.com> * vdk-jobs-troubleshooting: remove unused import Remove unused import. Signed-off-by: Dako Dakov <ddakov@vmware.com> * vdk-jobs-troubleshooting: Address review feedback Remove redundancies. Signed-off-by: Dako Dakov <ddakov@vmware.com> Signed-off-by: Andon Andonov <andonova@vmware.com> Signed-off-by: Dako Dakov <ddakov@vmware.com> Co-authored-by: ddakov <ddakov@vmware.com>
duyguHsnHsn
pushed a commit
that referenced
this pull request
Jan 6, 2023
* vdk-jobs-troubleshooting: Add thread-dump utility This change adds the implementation of a thread-dump utility to the vdk-jobs-troubleshooting plugin. The utility uses an http server, through which an administrator is able to force a stacktrace dump of all threads used by the python process of the data job. The server is bound to a port on the localhost, so to get the stacktrace, one needs to be attached to the data job pod. Testing Done: Added unit tests for the utility registry, and tested the plugin itself locally by running a simple data job and examining the execution logs. Signed-off-by: Andon Andonov <andonova@vmware.com> * vdk-jobs-troubleshooting: Add functional test Add functional test. Minor code refactoring. Signed-off-by: Dako Dakov <ddakov@vmware.com> * vdk-jobs-troubleshooting: Address review feedback Add documentation. Remove redundant Optional type. Signed-off-by: Dako Dakov <ddakov@vmware.com> * vdk-jobs-troubleshooting: remove unused import Remove unused import. Signed-off-by: Dako Dakov <ddakov@vmware.com> * vdk-jobs-troubleshooting: remove unused import Remove unused import. Signed-off-by: Dako Dakov <ddakov@vmware.com> * vdk-jobs-troubleshooting: Address review feedback Remove redundancies. Signed-off-by: Dako Dakov <ddakov@vmware.com> Signed-off-by: Andon Andonov <andonova@vmware.com> Signed-off-by: Dako Dakov <ddakov@vmware.com> Co-authored-by: ddakov <ddakov@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the implementation of a thread-dump utility to the vdk-jobs-troubleshooting plugin.
The utility uses an http server, through which an administrator is able to force a stacktrace dump of all threads used by the python process of the data job. The server is bound to a port on the localhost, so to get the stacktrace, one needs to be attached to the data job pod.
Testing Done: Added unit tests for the utility registry, and tested the plugin itself locally by running a simple data job and examining the execution logs.
Signed-off-by: Andon Andonov andonova@vmware.com