control-service: graphql wildcard matching filter for team and job names #1459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
mrMoZ1
force-pushed
the
person/mzhivkov/graphql-matchers
branch
from
f42d19e
to
9e6bb3f
Compare
|
LGTM! We should apply this change to the rest of the String properties provided by jobsQuery but in a separate PR. |
|
Also, we need IT test for this feature. |
murphp15
approved these changes
Dec 19, 2022
gageorgiev
approved these changes
Dec 19, 2022
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
mivanov1988
approved these changes
Dec 19, 2022
...src/main/java/com/vmware/taurus/service/graphql/strategy/datajob/JobFieldStrategyByName.java
Outdated
Show resolved
Hide resolved
|
Please update the documentation at api.yaml definition. You may add new example covering the new additions |
mrMoZ1
pushed a commit
that referenced
this pull request
Feb 13, 2023
…1615) what: reverted some of the changes introduced in #1459 . Reverted code and removed relevant tests. why: users of the control-service have had a hard time adjusting to the changes, and we agreed to roll them out in a more controlled manner, one by one for each filter/search field individually. testing: n/a since the change reverts to old functionality, existing tests already cover it. Signed-off-by: Momchil Zhivkov <mzhivkov@vmware.com> --------- Signed-off-by: mrMoZ1 <mzhivkov@vmware.com> Co-authored-by: github-actions <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what: Added wildcard matching e.g -search- in graphQl filters for job name and team name and exact matching of search strings.
why: Current implementation uses Java String's .contains() method which doesn't have the ability to return exact matches. Users of the control-service API ran into usability issues when multiple results were returned, without the ability to filter for exact matches.
testing: added tests.
Signed-off-by: Momchil Zhivkov mzhivkov@vmware.com