vdk-jupyter: python subprocess security problem #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
gageorgiev
approved these changes
Dec 22, 2022
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/vdk-jupyterlab-extension/vdk.py
Show resolved
Hide resolved
ivakoleva
requested changes
Jan 3, 2023
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/vdk-jupyterlab-extension/vdk.py
Outdated
Show resolved
Hide resolved
|
Please add (to PR description) links to the subprocess security guidelines you had I'm mind when creating this fix |
ivakoleva
reviewed
Jan 3, 2023
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/vdk-jupyterlab-extension/vdk.py
Show resolved
Hide resolved
ivakoleva
approved these changes
Jan 3, 2023
murphp15
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This PR introduce a small change that can lower the vulnerability of subprocess call in JupyterLab extension.
Why:
Possible security implications associated with subprocess module are present in JupyterLab Extension. There should be checks for untrusted input from the user when we call subprocess.call or subprocess.Popen. Currently, the module shlex is used which decreases the vulnerability but it is only designed for Unix shells.
You can see https://semgrep.dev/docs/cheat-sheets/python-command-injection/ for more
Signed-off-by: Duygu Hasan hduygu@vmware.com