Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vep-1416: Address feedback and update proposal #1491

Merged
merged 2 commits into from
Jan 10, 2023
Merged

Conversation

doks5
Copy link
Contributor

@doks5 doks5 commented Jan 10, 2023

This change addresses feedback received during previous reviews of vep-1416, and updates diagrams and document sections. More details about the vdk-jobs-troubleshooting plugin are added, as well as a section describing the HTTP server used by the thread-dump utility.

Testing done: N/A

Signed-off-by: Andon Andonov andonova@vmware.com

This change addresses feedback received during previous reviews of vep-1416, and
updates diagrams and document sections. More details about the vdk-jobs-troubleshooting
plugin are added, as well as a section describing the HTTP server used by the thread-dump
utility.

Testing done: N/A

Signed-off-by: Andon Andonov <andonova@vmware.com>
Copy link
Collaborator

@murphp15 murphp15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Collaborator

@duyguHsnHsn duyguHsnHsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good

@doks5 doks5 merged commit a95da52 into main Jan 10, 2023
@doks5 doks5 deleted the person/andonova/vep-update branch January 10, 2023 14:54
@doks5
Copy link
Contributor Author

doks5 commented Jan 10, 2023

Thank you for the reviews, @murphp15 @duyguHsnHsn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants