vdk-control-service: fix null dereferences #1512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why? Fix null dereference uncovered by coverity scaner What? Multiple changes mostly related to json conversions. What type of change are you making? Bug fix Signed-off-by: Dako Dakov ddakov@vmware.com
re-run tests Signed-off-by: Dako Dakov ddakov@vmware.com
|
Hey some of these are good finds. |
murphp15
reviewed
Jan 15, 2023
...s/control-service/projects/base/src/main/java/com/vmware/taurus/service/diag/HttpTracer.java
Outdated
Show resolved
Hide resolved
murphp15
reviewed
Jan 15, 2023
.../base/src/main/java/com/vmware/taurus/service/diag/methodintercept/DiagnosticsPublisher.java
Outdated
Show resolved
Hide resolved
murphp15
reviewed
Jan 15, 2023
.../projects/pipelines_control_service/src/main/java/com/vmware/taurus/service/JobsService.java
Outdated
Show resolved
Hide resolved
murphp15
reviewed
Jan 15, 2023
...rvice/src/main/java/com/vmware/taurus/service/credentials/KerberosCredentialsRepository.java
Outdated
Show resolved
Hide resolved
murphp15
approved these changes
Jan 15, 2023
Address review feedback. Signed-off-by: Dako Dakov ddakov@vmware.com
Address review feedback. Signed-off-by: Dako Dakov ddakov@vmware.com
mivanov1988
approved these changes
Jan 17, 2023
antoniivanov
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Fix null dereference uncovered by coverity scaner
What?
Multiple changes mostly related to json conversions.
What type of change are you making?
Bug fix
Signed-off-by: Dako Dakov ddakov@vmware.com