vdk-jupyter: improve error handling on the UI #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you include a screenshot of what it looks like? |
murphp15
reviewed
Jan 20, 2023
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/commandsAndMenu.tsx
Outdated
Show resolved
Hide resolved
murphp15
reviewed
Jan 20, 2023
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/serverRequests.ts
Outdated
Show resolved
Hide resolved
murphp15
reviewed
Jan 20, 2023
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/serverRequests.ts
Outdated
Show resolved
Hide resolved
duyguHsnHsn
force-pushed
the
person/hduygu/vdk-jupyter-ui-errors
branch
from
d323aaa
to
a4e1498
Compare
|
This is an example error for downloading a job |
murphp15
approved these changes
Jan 23, 2023
antoniivanov
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This PR introduces a new way to handle errors in the Jupyter UI, using a function called showErrorMessage from jupyterlab/apputils ( you can see https://jupyterlab.readthedocs.io/en/stable/api/modules/apputils.html )
Why: Up to now we used to console log the errors we et on the UI (mainly to check the behaviour of the extension).
Testing: Tested the dialogs manually
PS: test for the whole UI are u to be introduced soon
Signed-off-by: Duygu Hasan hduygu@vmware.com