-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README #1535
Update README #1535
Conversation
gary-tai
commented
Jan 21, 2023
- re-organized content
- added and clarified information
- removed redundant information
@gary-tai, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed. |
Hi Gary, and thanks for this contribution. @reviewers - you can see the rendered page at https://github.com/gary-tai/versatile-data-kit/tree/Update_README for easier review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some suggestions for small changes. But it looks very good to me.
Thanks again for the work.
It really looks good! But is removing all the installation information ok? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@gary-tai, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed. |
@gary-tai, VMware has approved your signed contributor license agreement. |
Hi, I will merge the change manually because I need to override Gitlab tests requirement. They cannot run from a fork (due to #854). |
I merged it now. Thanks, Gary, a lot for the suggested improvements. |