Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README #1535

Merged
merged 7 commits into from
Jan 26, 2023
Merged

Update README #1535

merged 7 commits into from
Jan 26, 2023

Conversation

gary-tai
Copy link
Collaborator

  • re-organized content
  • added and clarified information
  • removed redundant information

@vmwclabot
Copy link
Member

@gary-tai, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@vmwclabot
Copy link
Member

@gary-tai, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

@antoniivanov
Copy link
Collaborator

Hi Gary, and thanks for this contribution.

@reviewers - you can see the rendered page at https://github.com/gary-tai/versatile-data-kit/tree/Update_README for easier review.

Copy link
Collaborator

@antoniivanov antoniivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some suggestions for small changes. But it looks very good to me.

Thanks again for the work.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@duyguHsnHsn
Copy link
Collaborator

It really looks good! But is removing all the installation information ok?
I am asking because many similar tools as Kedro, Dagster, etc. include it.

README.md Show resolved Hide resolved
Copy link
Collaborator

@antoniivanov antoniivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@vmwclabot
Copy link
Member

@gary-tai, VMware has rejected your signed contributor license agreement. The merge can not proceed until the agreement has been resigned. Click here to resign the agreement. Reject reason:

Please provide full street address.

@vmwclabot
Copy link
Member

@gary-tai, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

@vmwclabot
Copy link
Member

@gary-tai, VMware has approved your signed contributor license agreement.

@antoniivanov
Copy link
Collaborator

Hi,

I will merge the change manually because I need to override Gitlab tests requirement. They cannot run from a fork (due to #854).

@antoniivanov antoniivanov merged commit b6aa9d5 into vmware:main Jan 26, 2023
@antoniivanov
Copy link
Collaborator

I merged it now. Thanks, Gary, a lot for the suggested improvements.

@gary-tai gary-tai deleted the Update_README branch January 26, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants