vdk-test-utils: add cli_assert_output_contains #1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniivanov
force-pushed
the
person/aivanov/vdk-test-utils
branch
from
6145ee1
to
8d62a1c
Compare
We may need to verify that something exists in output or some other verification. In the same time we'd like to make use of cli_assert more deetailed output in case of an error (prints output logs, thread dump of exception). This is extending `cli_assert` method to support passing custom message And addng new method cli_assert_output_contains which would test if output string contains substring. As this is frequently used verification method in a lot of plugins. new unit tests Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
antoniivanov
force-pushed
the
person/aivanov/vdk-test-utils
branch
from
8d62a1c
to
8134f89
Compare
doks5
approved these changes
Jan 24, 2023
projects/vdk-plugins/vdk-test-utils/src/vdk/plugin/test_utils/util_funcs.py
Outdated
Show resolved
Hide resolved
…util_funcs.py Co-authored-by: Andy <87700128+doks5@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may need to verify that something exists in output or some other verification. In the same time we'd like to make use of cli_assert more deetailed output in case of an error (prints output logs, thread dump of exception).
This is extending
cli_assertmethod to support passing custom message. And adding new methodcli_assert_output_containswhich would test if output string contains substring. As this is frequently used verification method in a lot of plugins.Testing Done: new unit tests
Signed-off-by: Antoni Ivanov aivanov@vmware.com