control-service: only delete file in test path #1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: murphp15 <murphp15@tcd.ie>
|
How did you catch the regression ? Did vdk-heartbeat post deployment test fail? It seems so. That's good. That's the purpose of the test to catch issues in real deployment. Or was some other way ? |
antoniivanov
approved these changes
Jan 24, 2023
|
The integration test is now failing btw. Maybe we need a flag or something like this to control the behaviour ... ? |
Yeah was caught by the heartbeart test |
mivanov1988
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
In my previous PR I merged code which deletes an empty keytab file, so that we keep only the filename.
This is the desired behaviour for the test kdc server as it expects no file to be at the file location.
However the production path expects there to be an empty file there.
What
Push the delete logic into the test impl so that we aren't modifying the production code path.
How has this been tested
entire deployment pipeline
Open questions
Should more of the pipeline run on branches as it would have caught this issue?
Signed-off-by: murphp15 murphp15@tcd.ie