Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

control-service: Fix release step in pipeline #1550

Merged
merged 17 commits into from
Jan 25, 2023

Conversation

murphp15
Copy link
Collaborator

@murphp15 murphp15 commented Jan 25, 2023

Why

The release step fails with the newer docker image version. But works with the previous setup.We need the newer version for java 17 support for other steps.

What

Revert the changes for that step only.

How has this been tested?

Tested on the previous commit and changes reverted to merge.

Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
@murphp15 murphp15 changed the title DRAFT Person/murphp15/fix release control-service: Fix release step in pipeline Jan 25, 2023
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
@antoniivanov
Copy link
Collaborator

Why does it fail ? Can you link and copy paste the failure? Can we fix it?

But first let's merge this as I understand the main pipeline is red and fixing the main branch CICD pipeline this is highest priority

@murphp15
Copy link
Collaborator Author

@murphp15 murphp15 enabled auto-merge (squash) January 25, 2023 12:47
Signed-off-by: murphp15 <murphp15@tcd.ie>
@murphp15 murphp15 merged commit 5102f89 into main Jan 25, 2023
@murphp15 murphp15 deleted the person/murphp15/fix-release branch January 25, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants