Control service: remove deprecated dependency #1589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
murphp15
changed the title
|
This seems to follow the migration guide closely, so no problem with the code itself. I'm just curious if and how the security config is tested. |
ivakoleva
approved these changes
Feb 3, 2023
The test KerberosAuthenticationIT tests the kerb authentication. |
mivanov1988
approved these changes
Feb 6, 2023
|
LGTM |
murphp15
commented
Feb 6, 2023
...ol-service/projects/base/src/main/java/com/vmware/taurus/security/SecurityConfiguration.java
Outdated
Show resolved
Hide resolved
Signed-off-by: murphp15 <murphp15@tcd.ie>
murphp15
deleted the
person/murphp15/remove_dependency_on_deprecated_class
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
At the moment we are blocked on spring upgrades because we are using a number of legacy classes. #1530
This remove one of those dependencies.
Even after this is merged I don't expect that PR to be fixed as there will be a number of other issues but this is a good first step
What
I followed the guidelines here on how to remove it https://spring.io/blog/2022/02/21/spring-security-without-the-websecurityconfigureradapter
Closes: #1590
Signed-off-by: murphp15 murphp15@tcd.ie