Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

control-service: Remove duplicated CICD job runs #1596

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

mivanov1988
Copy link
Contributor

Why

The pipeline which runs after the merge on the main branch is not very efficient. More details can be found here - #1593

What

  1. control_service_build_image and control_service_integration_test jobs are disabled as they are executed in the PR pipeline.
  2. Disabled unit tests for the control_service_publish_image job

Testing done

Local execution of Gradle commands

Signed-off-by: Miroslav Ivanov miroslavi@vmware.com

Why
The pipeline which runs after the merge on main branch is not very efficient.

What
1. control_service_build_image and control_service_integration_test jobs are disabled as they are executed in the PR pipeline.
2. Disabled unit tests for control_service_publish_image job
@mivanov1988 mivanov1988 changed the title control-service: optimize CI/CD control-service: CI/CD optimization Feb 6, 2023
Copy link
Contributor

@gageorgiev gageorgiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, the PR title is ambiguous, rewording it to something like "control-service: Remove duplicated CICD job runs" would be better IMO but its not a big deal

@mivanov1988 mivanov1988 changed the title control-service: CI/CD optimization control-service: Remove duplicated CICD job runs Feb 6, 2023
@mivanov1988
Copy link
Contributor Author

looks good, the PR title is ambiguous, rewording it to something like "control-service: Remove duplicated CICD job runs" would be better IMO but its not a big deal

Done, thanks.

@mivanov1988 mivanov1988 merged commit 2825884 into main Feb 6, 2023
@mivanov1988 mivanov1988 deleted the person/miroslavi/optimize-ci-cd branch February 6, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants