vdk-jupyter: Jupyter UI change the strategy on storing the data from user input #1624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
I got it, this change aims to shift the session-scoped data to conversation-scoped one. |
ivakoleva
reviewed
Feb 16, 2023
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/components/CreateJob.tsx
Outdated
Show resolved
Hide resolved
for more information, see https://pre-commit.ci
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/components/CreateJob.tsx
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/dataClasses/jobData.ts
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/vdk-jupyterlab-extension/handlers.py
Outdated
Show resolved
Hide resolved
DeltaMichael
approved these changes
Feb 20, 2023
ivakoleva
reviewed
Feb 20, 2023
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/vdk-jupyterlab-extension/vdk_ui.py
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/vdk-jupyterlab-extension/vdk_ui.py
Outdated
Show resolved
Hide resolved
ivakoleva
reviewed
Feb 20, 2023
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/vdk-jupyterlab-extension/handlers.py
Outdated
Show resolved
Hide resolved
ivakoleva
reviewed
Feb 20, 2023
...cts/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/vdk-jupyterlab-extension/dict_object.py
Outdated
Show resolved
Hide resolved
ivakoleva
reviewed
Feb 20, 2023
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/vdk-jupyterlab-extension/handlers.py
Outdated
Show resolved
Hide resolved
duyguHsnHsn
force-pushed
the
person/hduygu/vdk-jupyter-ui-change-data-storage-strategy
branch
from
b481a88
to
8f7090a
Compare
for more information, see https://pre-commit.ci
ivakoleva
approved these changes
Feb 22, 2023
...k-plugins/vdk-jupyter/vdk-jupyterlab-extension/vdk-jupyterlab-extension/ui_job_properties.py
Outdated
Show resolved
Hide resolved
...k-plugins/vdk-jupyter/vdk-jupyterlab-extension/vdk-jupyterlab-extension/ui_job_properties.py
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/jobData.ts
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/jobData.ts
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/jobData.ts
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/jobData.ts
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/README.md
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/README.md
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/README.md
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/components/RunJob.tsx
Outdated
Show resolved
Hide resolved
for more information, see https://pre-commit.ci
ivakoleva
approved these changes
Feb 23, 2023
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/vdk-jupyterlab-extension/vdk_ui.py
Outdated
Show resolved
Hide resolved
duyguHsnHsn
force-pushed
the
person/hduygu/vdk-jupyter-ui-change-data-storage-strategy
branch
from
3ac0b8b
to
c6ace5e
Compare
for more information, see https://pre-commit.ci
duyguHsnHsn
deleted the
person/hduygu/vdk-jupyter-ui-change-data-storage-strategy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Changed the strategy on storing the data from user input for each vdk operation.
Why:
It is linked to the #1484
It is also linked to the problem - saving SessionStorage data is really error-prone. SessionStorage keys are pure strings and even a single typo can create many unwanted behaviour of the project.
With this solution we remove the sessionStorage saved data and save them in global variables which are dataclasses that describe the input data from a user for specific vdk operation.
Note: If this solution is reviewed better than the current solution with the SessionStorage, the #1621 PR will be removed
Signed-off-by: Duygu Hasan hduygu@vmware.com