frontend: data-pipelines (#3) lib bundle sources #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabadzhiev
reviewed
Feb 14, 2023
...ines/gui/projects/data-pipelines/src/lib/components/data-job/data-job-page.component.spec.ts
Show resolved
Hide resolved
...-pipelines/src/lib/components/data-job/pages/details/data-job-details-page.component.spec.ts
Show resolved
Hide resolved
...nts/data-job/pages/executions/execution-duration-chart/execution-duration-chart.component.ts
Show resolved
Hide resolved
...ib/components/data-job/pages/executions/time-period-filter/time-period-filter.component.scss
Show resolved
Hide resolved
...nes/src/lib/components/data-jobs-manage/components/grid/data-jobs-manage-grid.component.html
Outdated
Show resolved
Hide resolved
...nd/data-pipelines/gui/projects/data-pipelines/src/lib/services/data-jobs-base.api.service.ts
Outdated
Show resolved
Hide resolved
|
Can you please open a ticket for the SCA issues? Or should I add them to the existing one? #1623 |
This is a stacked PR #3: data-pipelines lib bundle sources. Sources added. `public-api.ts` explains the user-facing API for lib import usages. Testing done: fetched the `frontend/shared-components` changes (from person/mdilyan/os-shared-components feature branch in review), and verified `frontend/data-pipelines` manual start + unit + e2e tests. Signed-off-by: ivakoleva <iva.koleva@clearcode.bg>
This is a stacked PR #3: data-pipelines lib bundle sources. Sources added. `public-api.ts` explains the user-facing API for lib import usages. Testing done: fetched the `frontend/shared-components` changes (from person/mdilyan/os-shared-components feature branch in review), and verified `frontend/data-pipelines` manual start + unit + e2e tests. Signed-off-by: ivakoleva <iva.koleva@clearcode.bg>
ivakoleva
force-pushed
the
person/ikoleva/frontend-data-pipelines-3
branch
from
943d6a1
to
22a5154
Compare
for more information, see https://pre-commit.ci
This is a stacked PR #3: data-pipelines lib bundle sources. Sources added. `public-api.ts` explains the user-facing API for lib import usages. Testing done: fetched the `frontend/shared-components` changes (from person/mdilyan/os-shared-components feature branch in review), and verified `frontend/data-pipelines` manual start + unit + e2e tests. Signed-off-by: ivakoleva <iva.koleva@clearcode.bg>
sabadzhiev
approved these changes
Feb 17, 2023
.../lib/components/data-job/pages/executions/time-period-filter/time-period-filter.component.ts
Show resolved
Hide resolved
...nes/src/lib/components/data-jobs-explore/components/grid/data-jobs-explore-grid.component.ts
Show resolved
Hide resolved
Generalised the existing ticket, since problems could be quite very common, so I don't want to do same work twice |
DeltaMichael
approved these changes
Feb 17, 2023
ivakoleva
added a commit
that referenced
this pull request
Feb 17, 2023
This is a stacked PR #4 (follows #1630): data-pipelines ui bundle ceremonies. Assets added. Project and artifact bundle configurations added. Testing done: fetched the `frontend/shared-components` changes (from person/mdilyan/os-shared-components feature branch in review), and verified `frontend/data-pipelines` manual start + unit + e2e tests. --------- Signed-off-by: ivakoleva <iva.koleva@clearcode.bg> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
DeltaMichael
pushed a commit
to DeltaMichael/versatile-data-kit
that referenced
this pull request
Feb 17, 2023
This is a stacked PR vmware#4 (follows vmware#1630): data-pipelines ui bundle ceremonies. Assets added. Project and artifact bundle configurations added. Testing done: fetched the `frontend/shared-components` changes (from person/mdilyan/os-shared-components feature branch in review), and verified `frontend/data-pipelines` manual start + unit + e2e tests. --------- Signed-off-by: ivakoleva <iva.koleva@clearcode.bg> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
ivakoleva
added a commit
that referenced
this pull request
Feb 20, 2023
This is a stacked PR #3 (follows #1629): data-pipelines lib bundle sources. Sources added. `public-api.ts` explains the user-facing API for lib import usages. Testing done: fetched the `frontend/shared-components` changes (from person/mdilyan/os-shared-components feature branch in review), and verified `frontend/data-pipelines` manual start + unit + e2e tests. --------- Signed-off-by: ivakoleva <iva.koleva@clearcode.bg> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
ivakoleva
added a commit
that referenced
this pull request
Feb 20, 2023
This is a stacked PR #4 (follows #1630): data-pipelines ui bundle ceremonies. Assets added. Project and artifact bundle configurations added. Testing done: fetched the `frontend/shared-components` changes (from person/mdilyan/os-shared-components feature branch in review), and verified `frontend/data-pipelines` manual start + unit + e2e tests. --------- Signed-off-by: ivakoleva <iva.koleva@clearcode.bg> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a stacked PR #3 (follows #1629):
data-pipelines lib bundle sources.
Sources added.
public-api.tsexplains the user-facing API for lib import usages.Testing done: fetched the
frontend/shared-componentschanges(from person/mdilyan/os-shared-components feature branch in review),
and verified
frontend/data-pipelinesmanual start + unit + e2e tests.