versatile-data-kit: Meta Job example #1640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces a wiki example demonstrating how a user could implement a Meta Job and component jobs. Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
dvalkova
reviewed
Feb 16, 2023
|
I went through the README and the sample data jobs. I think the example is great, easy to follow, with no unnecessary text or explanations. The only thing I would add to the README is a short explanation about the MetaJobInput interface - just 1-2 sentences to stress on the fact that this is a different interface to the IJobInput we're used to using (or maybe add just a comment in the meta job script about that). This is not a requirement, you can decide whether to implement it. |
victor-partico
approved these changes
Feb 16, 2023
Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
for more information, see https://pre-commit.ci
ivakoleva
pushed a commit
that referenced
this pull request
Feb 20, 2023
This PR introduces a wiki example demonstrating how a user could implement a Meta Job and component jobs. Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a wiki example demonstrating how a user could implement a Meta Job and component jobs.
Signed-off-by: Gabriel Georgiev gageorgiev@vmware.com