-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend: data-pipelines build and test running CI/CD #1671
frontend: data-pipelines build and test running CI/CD #1671
Conversation
...-pipelines/src/lib/components/data-job/pages/details/data-job-details-page.component.spec.ts
Outdated
Show resolved
Hide resolved
I was once told (when our open source team was reviewing our commit history) that if we have bullet points in the commit message, a change is doing too many things and should have been split. Since then when I catch myself that I make bullet points or start saying "fixing this and that" I consider if I should better split it into 2 or more. I thought that was good advice and I am passing it on. |
I generally agree, it's a good advice. When you are open sourcing an existing component, a lot of stuff are known and also tested & verified already in advance. So, I also think it is normal to be confident with enumerating the changes, it rather depends on the context. |
Yes I agree, for that specific case, we are fine. I wanted to note this advice because the change reminded me. |
I actually think 11 files is a pretty standard amount of file changes. The PR description does not contain bullets, it contains logical steps that the install script performs, that would be an atomic change (since the script is an atomic item itself). So I don't think artificially splitting the script, in a series of PRs, would be practical. I considered splitting the import fixes, but decided not to due arguments listed in #1671 (comment) |
e5150e8
to
3e2935e
Compare
9254375
to
e2e7986
Compare
We need to build and run unit tests of data-pipelines library and ui application that uses it. The component is dependent on shared-components library. Added Bash scripts to (1) link if any shared-components rebuild was made and is about to be published, or otherwise default to latest already published one (2) build the data-pipelines library and link @vdk/data-pipelines (3) build the UI application (4) lint the subprojects to verify format (5) run the unit tests One bash script is meant to be used to satisfy build prerequisites, the other one to rebuild and relink continuously, needed during development. The proposed implementation triggers a data-pipelines rebuild (+test), upon any shared-components change, as well as data-pipelines changes. A few functional import fixes were made, to import the correctly renamed class. A README.md link fix to the VEP. Testing done: run the install script (that evaluates the build script) on a clean setup, and verified the unit tests were successful. Also, did start and browse the application manually, to check its operational. Signed-off-by: ivakoleva <iva.koleva@clearcode.bg>
We need to build and run unit tests of data-pipelines library and ui application that uses it. The component is dependent on shared-components library. Added Bash scripts to (1) link if any shared-components rebuild was made and is about to be published, or otherwise default to latest already published one (2) build the data-pipelines library and link @vdk/data-pipelines (3) build the UI application (4) lint the subprojects to verify format (5) run the unit tests One bash script is meant to be used to satisfy build prerequisites, the other one to rebuild and relink continuously, needed during development. The proposed implementation triggers a data-pipelines rebuild (+test), upon any shared-components change, as well as data-pipelines changes. A few functional import fixes were made, to import the correctly renamed class. A README.md link fix to the VEP. Testing done: run the install script (that evaluates the build script) on a clean setup, and verified the unit tests were successful. Also, did start and browse the application manually, to check its operational. Signed-off-by: ivakoleva <iva.koleva@clearcode.bg>
We need to build and run unit tests of data-pipelines library and ui application that uses it. The component is dependent on shared-components library. Added Bash scripts to (1) link if any shared-components rebuild was made and is about to be published, or otherwise default to latest already published one (2) build the data-pipelines library and link @vdk/data-pipelines (3) build the UI application (4) lint the subprojects to verify format (5) run the unit tests One bash script is meant to be used to satisfy build prerequisites, the other one to rebuild and relink continuously, needed during development. The proposed implementation triggers a data-pipelines rebuild (+test), upon any shared-components change, as well as data-pipelines changes. A few functional import fixes were made, to import the correctly renamed class. A README.md link fix to the VEP. Testing done: run the install script (that evaluates the build script) on a clean setup, and verified the unit tests were successful. Also, did start and browse the application manually, to check its operational. Signed-off-by: ivakoleva <iva.koleva@clearcode.bg>
We need to build and run unit tests of data-pipelines library and ui application that uses it. The component is dependent on shared-components library. Added Bash scripts to (1) link if any shared-components rebuild was made and is about to be published, or otherwise default to latest already published one (2) build the data-pipelines library and link @vdk/data-pipelines (3) build the UI application (4) lint the subprojects to verify format (5) run the unit tests One bash script is meant to be used to satisfy build prerequisites, the other one to rebuild and relink continuously, needed during development. The proposed implementation triggers a data-pipelines rebuild (+test), upon any shared-components change, as well as data-pipelines changes. A few functional import fixes were made, to import the correctly renamed class. A README.md link fix to the VEP. Testing done: run the install script (that evaluates the build script) on a clean setup, and verified the unit tests were successful. Also, did start and browse the application manually, to check its operational. Signed-off-by: ivakoleva <iva.koleva@clearcode.bg>
We need to build and run unit tests of data-pipelines library and ui application that uses it. The component is dependent on shared-components library. Added Bash scripts to (1) link if any shared-components rebuild was made and is about to be published, or otherwise default to latest already published one (2) build the data-pipelines library and link @vdk/data-pipelines (3) build the UI application (4) lint the subprojects to verify format (5) run the unit tests One bash script is meant to be used to satisfy build prerequisites, the other one to rebuild and relink continuously, needed during development. The proposed implementation triggers a data-pipelines rebuild (+test), upon any shared-components change, as well as data-pipelines changes. A few functional import fixes were made, to import the correctly renamed class. A README.md link fix to the VEP. Testing done: run the install script (that evaluates the build script) on a clean setup, and verified the unit tests were successful. Also, did start and browse the application manually, to check its operational. Signed-off-by: ivakoleva <iva.koleva@clearcode.bg>
We need to build and run unit tests of data-pipelines library and ui application that uses it. The component is dependent on shared-components library. Added Bash scripts to (1) link if any shared-components rebuild was made and is about to be published, or otherwise default to latest already published one (2) build the data-pipelines library and link @vdk/data-pipelines (3) build the UI application (4) lint the subprojects to verify format (5) run the unit tests One bash script is meant to be used to satisfy build prerequisites, the other one to rebuild and relink continuously, needed during development. The proposed implementation triggers a data-pipelines rebuild (+test), upon any shared-components change, as well as data-pipelines changes. A few functional import fixes were made, to import the correctly renamed class. A README.md link fix to the VEP. Testing done: run the install script (that evaluates the build script) on a clean setup, and verified the unit tests were successful. Also, did start and browse the application manually, to check its operational. Signed-off-by: ivakoleva <iva.koleva@clearcode.bg>
We need to build and run unit tests of data-pipelines library and ui application that uses it. The component is dependent on shared-components library. Added Bash scripts to (1) link if any shared-components rebuild was made and is about to be published, or otherwise default to latest already published one (2) build the data-pipelines library and link @vdk/data-pipelines (3) build the UI application (4) lint the subprojects to verify format (5) run the unit tests One bash script is meant to be used to satisfy build prerequisites, the other one to rebuild and relink continuously, needed during development. The proposed implementation triggers a data-pipelines rebuild (+test), upon any shared-components change, as well as data-pipelines changes. A few functional import fixes were made, to import the correctly renamed class. A README.md link fix to the VEP. Testing done: run the install script (that evaluates the build script) on a clean setup, and verified the unit tests were successful. Also, did start and browse the application manually, to check its operational. Signed-off-by: ivakoleva <iva.koleva@clearcode.bg>
We need to build and run unit tests of data-pipelines library and ui application that uses it. The component is dependent on shared-components library. Added Bash scripts to (1) link if any shared-components rebuild was made and is about to be published, or otherwise default to latest already published one (2) build the data-pipelines library and link @vdk/data-pipelines (3) build the UI application (4) lint the subprojects to verify format (5) run the unit tests One bash script is meant to be used to satisfy build prerequisites, the other one to rebuild and relink continuously, needed during development. The proposed implementation triggers a data-pipelines rebuild (+test), upon any shared-components change, as well as data-pipelines changes. A few functional import fixes were made, to import the correctly renamed class. A README.md link fix to the VEP. Testing done: run the install script (that evaluates the build script) on a clean setup, and verified the unit tests were successful. Also, did start and browse the application manually, to check its operational. Signed-off-by: ivakoleva <iva.koleva@clearcode.bg>
We need to build and run unit tests of data-pipelines library and ui application that uses it. The component is dependent on shared-components library. Added Bash scripts to (1) link if any shared-components rebuild was made and is about to be published, or otherwise default to latest already published one (2) build the data-pipelines library and link @vdk/data-pipelines (3) build the UI application (4) lint the subprojects to verify format (5) run the unit tests One bash script is meant to be used to satisfy build prerequisites, the other one to rebuild and relink continuously, needed during development. The proposed implementation triggers a data-pipelines rebuild (+test), upon any shared-components change, as well as data-pipelines changes. A few functional import fixes were made, to import the correctly renamed class. A README.md link fix to the VEP. Testing done: run the install script (that evaluates the build script) on a clean setup, and verified the unit tests were successful. Also, did start and browse the application manually, to check its operational. Signed-off-by: ivakoleva <iva.koleva@clearcode.bg>
We need to build and run unit tests of data-pipelines library and ui application that uses it. The component is dependent on shared-components library. Added Bash scripts to (1) link if any shared-components rebuild was made and is about to be published, or otherwise default to latest already published one (2) build the data-pipelines library and link @vdk/data-pipelines (3) build the UI application (4) lint the subprojects to verify format (5) run the unit tests One bash script is meant to be used to satisfy build prerequisites, the other one to rebuild and relink continuously, needed during development. The proposed implementation triggers a data-pipelines rebuild (+test), upon any shared-components change, as well as data-pipelines changes. A few functional import fixes were made, to import the correctly renamed class. A README.md link fix to the VEP. Testing done: run the install script (that evaluates the build script) on a clean setup, and verified the unit tests were successful. Also, did start and browse the application manually, to check its operational. Signed-off-by: ivakoleva <iva.koleva@clearcode.bg>
We need to build and run unit tests of data-pipelines library and ui application that uses it. The component is dependent on shared-components library. Added Bash scripts to (1) link if any shared-components rebuild was made and is about to be published, or otherwise default to latest already published one (2) build the data-pipelines library and link @vdk/data-pipelines (3) build the UI application (4) lint the subprojects to verify format (5) run the unit tests One bash script is meant to be used to satisfy build prerequisites, the other one to rebuild and relink continuously, needed during development. The proposed implementation triggers a data-pipelines rebuild (+test), upon any shared-components change, as well as data-pipelines changes. A few functional import fixes were made, to import the correctly renamed class. A README.md link fix to the VEP. Testing done: run the install script (that evaluates the build script) on a clean setup, and verified the unit tests were successful. Also, did start and browse the application manually, to check its operational. Signed-off-by: ivakoleva <iva.koleva@clearcode.bg>
We need to build and run unit tests of data-pipelines library and ui application that uses it. The component is dependent on shared-components library. Added Bash scripts to (1) link if any shared-components rebuild was made and is about to be published, or otherwise default to latest already published one (2) build the data-pipelines library and link @vdk/data-pipelines (3) build the UI application (4) lint the subprojects to verify format (5) run the unit tests One bash script is meant to be used to satisfy build prerequisites, the other one to rebuild and relink continuously, needed during development. The proposed implementation triggers a data-pipelines rebuild (+test), upon any shared-components change, as well as data-pipelines changes. A few functional import fixes were made, to import the correctly renamed class. A README.md link fix to the VEP. Testing done: run the install script (that evaluates the build script) on a clean setup, and verified the unit tests were successful. Also, did start and browse the application manually, to check its operational. Signed-off-by: ivakoleva <iva.koleva@clearcode.bg>
We need to build and run unit tests of data-pipelines library and ui application that uses it. The component is dependent on shared-components library. Added Bash scripts to (1) link if any shared-components rebuild was made and is about to be published, or otherwise default to latest already published one (2) build the data-pipelines library and link @vdk/data-pipelines (3) build the UI application (4) lint the subprojects to verify format (5) run the unit tests One bash script is meant to be used to satisfy build prerequisites, the other one to rebuild and relink continuously, needed during development. The proposed implementation triggers a data-pipelines rebuild (+test), upon any shared-components change, as well as data-pipelines changes. A few functional import fixes were made, to import the correctly renamed class. A README.md link fix to the VEP. Testing done: run the install script (that evaluates the build script) on a clean setup, and verified the unit tests were successful. Also, did start and browse the application manually, to check its operational. Signed-off-by: ivakoleva <iva.koleva@clearcode.bg>
f87b350
to
616816f
Compare
We need to build and run unit tests of data-pipelines library and ui application that uses it. The component is dependent on shared-components library. Added Bash scripts to (1) link if any shared-components rebuild was made and is about to be published, or otherwise default to latest already published one (2) build the data-pipelines library and link @vdk/data-pipelines (3) build the UI application (4) lint the subprojects to verify format (5) run the unit tests One bash script is meant to be used to satisfy build prerequisites, the other one to rebuild and relink continuously, needed during development. The proposed implementation triggers a data-pipelines rebuild (+test), upon any shared-components change, as well as data-pipelines changes. A README.md link fix to the VEP. Testing done: run the install script (that evaluates the build script) on a clean setup, and verified the unit tests were successful. Also, did start and browse the application manually, to check its operational. Signed-off-by: ivakoleva <iva.koleva@clearcode.bg>
We need to build and run unit tests of data-pipelines library and ui application that uses it. The component is dependent on shared-components library. Added Bash scripts to (1) link if any shared-components rebuild was made and is about to be published, or otherwise default to latest already published one (2) build the data-pipelines library and link @vdk/data-pipelines (3) build the UI application (4) lint the subprojects to verify format (5) run the unit tests One bash script is meant to be used to satisfy build prerequisites, the other one to rebuild and relink continuously, needed during development. The proposed implementation triggers a data-pipelines rebuild (+test), upon any shared-components change, as well as data-pipelines changes. A README.md link fix to the VEP. Testing done: run the install script (that evaluates the build script) on a clean setup, and verified the unit tests were successful. Also, did start and browse the application manually, to check its operational. Signed-off-by: ivakoleva <iva.koleva@clearcode.bg>
We need to build and run unit tests of data-pipelines library and ui application that uses it. The component is dependent on shared-components library. Added Bash scripts to (1) link if any shared-components rebuild was made and is about to be published, or otherwise default to latest already published one (2) build the data-pipelines library and link @vdk/data-pipelines (3) build the UI application (4) lint the subprojects to verify format (5) run the unit tests One bash script is meant to be used to satisfy build prerequisites, the other one to rebuild and relink continuously, needed during development. The proposed implementation triggers a data-pipelines rebuild (+test), upon any shared-components change, as well as data-pipelines changes. A README.md link fix to the VEP. Testing done: run the install script (that evaluates the build script) on a clean setup, and verified the unit tests were successful. Also, did start and browse the application manually, to check its operational. Signed-off-by: ivakoleva <iva.koleva@clearcode.bg>
We need to build and run unit tests of data-pipelines library and ui application that uses it. The component is dependent on shared-components library. Added Bash scripts to (1) link if any shared-components rebuild was made and is about to be published, or otherwise default to latest already published one (2) build the data-pipelines library and link @vdk/data-pipelines (3) build the UI application (4) lint the subprojects to verify format (5) run the unit tests One bash script is meant to be used to satisfy build prerequisites, the other one to rebuild and relink continuously, needed during development. The proposed implementation triggers a data-pipelines rebuild (+test), upon any shared-components change, as well as data-pipelines changes. A README.md link fix to the VEP. Testing done: run the install script (that evaluates the build script) on a clean setup, and verified the unit tests were successful. Also, did start and browse the application manually, to check its operational. Signed-off-by: ivakoleva <iva.koleva@clearcode.bg>
We need to build and run unit tests of data-pipelines library and ui application that uses it. The component is dependent on shared-components library. Added Bash scripts to (1) link if any shared-components rebuild was made and is about to be published, or otherwise default to latest already published one (2) build the data-pipelines library and link @vdk/data-pipelines (3) build the UI application (4) lint the subprojects to verify format (5) run the unit tests One bash script is meant to be used to satisfy build prerequisites, the other one to rebuild and relink continuously, needed during development. The proposed implementation triggers a data-pipelines rebuild (+test), upon any shared-components change, as well as data-pipelines changes. A README.md link fix to the VEP. Testing done: run the install script (that evaluates the build script) on a clean setup, and verified the unit tests were successful. Also, did start and browse the application manually, to check its operational. --------- Signed-off-by: ivakoleva <iva.koleva@clearcode.bg>
We need to build and run unit tests of data-pipelines library and ui application that uses it. The component is dependent on shared-components library.
Added Bash scripts to
(1) link if any shared-components rebuild was made and is about to be published, or otherwise default to latest already published one
(2) build the data-pipelines library and link @vdk/data-pipelines
(3) build the UI application
(4) lint the subprojects to verify format
(5) run the unit tests
One bash script is meant to be used to satisfy build prerequisites, the other one to rebuild and relink continuously, needed during development.
The proposed implementation triggers a data-pipelines rebuild (+test), upon any shared-components change, as well as data-pipelines changes.
A README.md link fix to the VEP.
Testing done: run the install script (that evaluates the build script) on a clean setup, and verified the unit tests were successful. Also, did start and browse the application manually, to check its operational.