vdk-trino: stabilize vdk-trino tests #1677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniivanov
force-pushed
the
person/aivanov/vdk-trino
branch
4 times, most recently
from
c8401e0
to
3899dc0
Compare
ivakoleva
reviewed
Feb 28, 2023
antoniivanov
force-pushed
the
person/aivanov/vdk-trino
branch
6 times, most recently
from
1dd2018
to
d9fc846
Compare
antoniivanov
changed the title
ivakoleva
approved these changes
Mar 1, 2023
This change is part of fixing vdk-trino which is failing regularly in the nightly builds . See #1559 Until now we used pytest-docker to start service container, this is switching it to testcontainers-python. There are multiple advanrages of using it. * Supposedly Testcontainers is built with performance in mind and uses a variety of techniques to minimize container startup time and resource usage like image reuse, container reuse, asynchronous operations. * It is far more popular lately - https://hugovk.github.io/top-pypi-packages/ is a site I frequently used to decide which library is likely to be more stable/used . It is showing testcontainers is 2000 places ahead of pytest-docker * Testcontainers provides a wider range of features for managing containers, such as starting and stopping them, waiting for them to become available, and exposing their ports to the host system * Testcontainers-Python allows you to define and configure containers using Python code instaed of yaml which pytest-docker required. Testing Done: ran the test suite of vdk-trino a few times and it was more stable and quick. I have not run actual benchmarks and recorded times but it seems abotu twice faster possibly. We will verify this as part of the nightly builds. Signed-off-by: Antoni Ivanov <aivanov@vmware.com> vdk-trino: debugging commit Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
antoniivanov
force-pushed
the
person/aivanov/vdk-trino
branch
from
ca57a0e
to
0a75a97
Compare
duyguHsnHsn
approved these changes
Mar 1, 2023
yonitoo
pushed a commit
that referenced
this pull request
Mar 1, 2023
This change is fixing vdk-trino tests which are failing regularly in the nightly builds . See #1559 The tests were failing intermittently for two main reasons * Docker failures which are being fixed by adopting testcontainers (in favour of pytest-docker) * Hidden dependencies between test cases (because different test use same schema and tables on shared db instance) Until now we used pytest-docker to start service container, this is switching it to testcontainers-python. There are multiple advantages of using it. * Supposedly Testcontainers is built with performance in mind and uses a variety of techniques to minimize container startup time and resource usage like image reuse, container reuse, asynchronous operations. * It is far more popular lately - https://hugovk.github.io/top-pypi-packages/ is a site I frequently use to decide which library is likely to be more stable/used . It is showing testcontainers is 2000 places ahead of pytest-docker * Testcontainers provides a wider range of features for managing containers, such as starting and stopping them, waiting for them to become available, and exposing their ports to the host system * Testcontainers-Python allows you to define and configure containers using Python code instead of yaml which pytest-docker required. Testing Done: ran the test suite of vdk-trino a few times and it was more stable and quick. I have not run actual benchmarks and recorded times but it seems about twice faster possibly. We will verify this as part of the nightly builds. Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is fixing vdk-trino tests which are failing regularly in the nightly builds . See
#1559
The tests were failing intermittently for two main reasons
Until now we used pytest-docker to start service container, this is switching it to testcontainers-python.
There are multiple advantages of using it.
Testing Done: ran the test suite of vdk-trino a few times and it was more stable and quick. I have not run actual benchmarks and recorded times but it seems about twice faster possibly. We will verify this as part of the nightly builds.