frontend: Rename vdk/shared to versatiledatakit/shared #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeltaMichael
force-pushed
the
person/mdilyan/rename-vdk-shared
branch
from
e2c1f5e
to
9e345a0
Compare
antoniivanov
approved these changes
Mar 2, 2023
Why Fixes the broken CI release job for vdk/shared. The account we publish to in the registry is called versatiledatakit. Registry only supports scoped packages, e.g. @something/something-else. We can't publish a package to that account, unless it matches the account, so it should be called @versatiledatakit/shared and not @vdk/shared. Otherwise, publishing fails What Rename all references for vdk/shared to versatiledatakit/shared Add package-lock.json to .gitignore Change description of package to not mention Taurus How has this been tested Tested the scripts by running them locally What type of change are you making Bugfix Signed-off-by: Dilyan Marinov <mdilyan@vmware.com>
DeltaMichael
force-pushed
the
person/mdilyan/rename-vdk-shared
branch
from
9e345a0
to
28a06b4
Compare
ivakoleva
approved these changes
Mar 2, 2023
yonitoo
pushed a commit
that referenced
this pull request
Mar 2, 2023
### Why
Fixes the broken CI release job for vdk/shared. The account we publish
to in
the registry is called versatiledatakit. Registry only supports scoped
packages,
e.g. @something/something-else. We can't publish a package to that
account,
unless it matches the account, so it should be called
@versatiledatakit/shared
and not @vdk/shared. Otherwise, publishing fails
### What
Rename all references for vdk/shared to versatiledatakit/shared
Add package-lock.json to .gitignore
Change description of package to not mention Taurus
### How has this been tested
Tested the scripts by running them locally
### What type of change are you making
Bugfix
Signed-off-by: Dilyan Marinov <mdilyan@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes the broken CI release job for vdk/shared. The account we publish to in
the registry is called versatiledatakit. Registry only supports scoped packages,
e.g. @something/something-else. We can't publish a package to that account,
unless it matches the account, so it should be called @versatiledatakit/shared
and not @vdk/shared. Otherwise, publishing fails
What
Rename all references for vdk/shared to versatiledatakit/shared
Add package-lock.json to .gitignore
Change description of package to not mention Taurus
How has this been tested
Tested the scripts by running them locally
What type of change are you making
Bugfix
Signed-off-by: Dilyan Marinov mdilyan@vmware.com