Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: compile fix #1697

Merged
merged 2 commits into from
Mar 2, 2023
Merged

frontend: compile fix #1697

merged 2 commits into from
Mar 2, 2023

Conversation

ivakoleva
Copy link
Contributor

Some shared-components class names had to be changed during open-sourcing.

Fixing the naming to match.

Testing done: verified locally (using the build/install scripts from wip PRs, to test cascade changes as well)

Some shared-components class names had to be changed during
open-sourcing.

Fixing the naming to match.

Testing done: verified locally (using the build/install scripts from
wip PRs, to test cascade changes as well)

Signed-off-by: ivakoleva <iva.koleva@clearcode.bg>
@ivakoleva ivakoleva enabled auto-merge (squash) March 2, 2023 14:11
Copy link
Contributor

@yonitoo yonitoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ivakoleva ivakoleva merged commit 1688c7b into main Mar 2, 2023
@ivakoleva ivakoleva deleted the person/ikoleva/frontnend-compile-fix branch March 2, 2023 14:20
yonitoo pushed a commit that referenced this pull request Mar 6, 2023
Some shared-components class names had to be changed during
open-sourcing.

Fixing the naming to match.

Testing done: verified locally (using the build/install scripts from wip
PRs, to test cascade changes as well)

Signed-off-by: ivakoleva <iva.koleva@clearcode.bg>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants