vdk-core: Remove @table column from base ingestion code #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While it is necessary when doing http ingestion, this column is not needed for database ingestion. So there is no need to always set this value, thus making it mandatory to create @table column for all ingestion targets. Remove code setting @table column in ingester_base send_object_for_ingestion. Tested by unit tests. Signed-off-by: Yana Zhivkova <yzhivkova@vmware.com>
gageorgiev
approved these changes
Sep 1, 2021
YanaZhivkova
deleted the
person/yzhivkova/Remove_vdk-core_base_ingestion_@table_column
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it is necessary when doing http ingestion, this column
is not needed for database ingestion. So there is no need to
always set this value, thus making it mandatory to create @table
column for all ingestion targets.
Remove code setting @table column in ingester_base
send_object_for_ingestion.
Tested by unit tests.
Signed-off-by: Yana Zhivkova yzhivkova@vmware.com