vdk-heartbeat: fix test failures #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniivanov
force-pushed
the
person/aivanov/vdk-heartbeat
branch
from
333f46b
to
4f202ee
Compare
gageorgiev
approved these changes
Mar 7, 2023
yonitoo
approved these changes
Mar 7, 2023
projects/vdk-heartbeat/tests/vdk/internal/test_trino_database_test.py
Outdated
Show resolved
Hide resolved
vdk-heartbeat test was failing with ``` FAILED tests/vdk/internal/test_trino_database_test.py::test_create_table - TypeError: '>' not supported between instances of 'MagicMock' and 'int' FAILED tests/vdk/internal/test_trino_database_test.py::test_delete_table - TypeError: '>' not supported between instances of 'MagicMock' and 'int' FAILED tests/vdk/internal/test_trino_database_test.py::test_insert_table_row - TypeError: '>' not supported between instances of 'MagicMock' and 'int' FAILED tests/vdk/internal/test_trino_database_test.py::test_select_data - TypeError: '>' not supported between instances of 'MagicMock' and 'int' ``` as seen at https://gitlab.com/vmware-analytics/versatile-data-kit/-/jobs/3876278808 Trying to fix this. Testing Done: this CI. Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
antoniivanov
force-pushed
the
person/aivanov/vdk-heartbeat
branch
from
4f202ee
to
6102dda
Compare
ivakoleva
pushed a commit
that referenced
this pull request
Mar 9, 2023
https://gitlab.com/vmware-analytics/versatile-data-kit/-/jobs/3876278808 was failing with ``` FAILED tests/vdk/internal/test_trino_database_test.py::test_create_table - TypeError: '>' not supported between instances of 'MagicMock' and 'int' FAILED tests/vdk/internal/test_trino_database_test.py::test_delete_table - TypeError: '>' not supported between instances of 'MagicMock' and 'int' FAILED tests/vdk/internal/test_trino_database_test.py::test_insert_table_row - TypeError: '>' not supported between instances of 'MagicMock' and 'int' FAILED tests/vdk/internal/test_trino_database_test.py::test_select_data - TypeError: '>' not supported between instances of 'MagicMock' and 'int' ``` Trying to fix this. Testing Done: this CI. Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://gitlab.com/vmware-analytics/versatile-data-kit/-/jobs/3876278808 was failing with
Trying to fix this.
Testing Done: this CI.