Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update VEP-1507 with CI/CD description #1707

Merged
merged 3 commits into from
Mar 14, 2023

Conversation

DeltaMichael
Copy link
Contributor

No description provided.

Copy link
Contributor

@ivakoleva ivakoleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LVGTM, lean and well made explanations. Looks great.
You can also try getting early feedback from frontend adopters.

specs/vep-1507-vdk-operations-ui/README.md Show resolved Hide resolved
specs/vep-1507-vdk-operations-ui/README.md Outdated Show resolved Hide resolved
specs/vep-1507-vdk-operations-ui/README.md Outdated Show resolved Hide resolved
specs/vep-1507-vdk-operations-ui/README.md Outdated Show resolved Hide resolved
specs/vep-1507-vdk-operations-ui/README.md Outdated Show resolved Hide resolved
specs/vep-1507-vdk-operations-ui/README.md Show resolved Hide resolved
specs/vep-1507-vdk-operations-ui/README.md Show resolved Hide resolved
specs/vep-1507-vdk-operations-ui/README.md Show resolved Hide resolved
specs/vep-1507-vdk-operations-ui/README.md Outdated Show resolved Hide resolved
specs/vep-1507-vdk-operations-ui/README.md Show resolved Hide resolved
Copy link
Collaborator

@antoniivanov antoniivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall design for CI/CD for frontend components looks solid. Below I have made suggestions that could enhance and make the design more clear.

specs/vep-1507-vdk-operations-ui/README.md Outdated Show resolved Hide resolved
specs/vep-1507-vdk-operations-ui/README.md Show resolved Hide resolved
specs/vep-1507-vdk-operations-ui/README.md Show resolved Hide resolved
@DeltaMichael DeltaMichael force-pushed the person/mdilyan/cicd-vep branch 3 times, most recently from f7f3da2 to 76518c6 Compare March 14, 2023 08:45
Dilyan Marinov added 2 commits March 14, 2023 10:47
Signed-off-by: Dilyan Marinov <mdilyan@vmware.com>
Signed-off-by: Dilyan Marinov <mdilyan@vmware.com>
@DeltaMichael DeltaMichael enabled auto-merge (squash) March 14, 2023 09:32
@DeltaMichael DeltaMichael merged commit 39f6c7b into main Mar 14, 2023
@DeltaMichael DeltaMichael deleted the person/mdilyan/cicd-vep branch March 14, 2023 09:52
ivakoleva pushed a commit that referenced this pull request Mar 16, 2023
Signed-off-by: Dilyan Marinov <mdilyan@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants