vdk-quickstart: remove use of global varaibles in CI #1726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of global variables in GitLab CI can create problems when multiple CI files are being imported, as variables are not scoped to a specific file. This can lead to unexpected variables being set, causing issues in the CI/CD pipeline. This is what is happening wiht quickstart-vdk test - https://gitlab.com/vmware-analytics/versatile-data-kit/-/jobs/3901914540 It expected that there's python installed because it's supposed to use python image but some other file overrides this image to docker and causes the test to fail. This changes quickstart-vdk to use job-level variables. In future changes I will be changing all CIs to use job-level variables or environment variables to avoid conflicts and ensure proper scoping. Or ensure that global variabels and labels are prefixed with the project or plugin name. Testing Done: this PR CI Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
antoniivanov
force-pushed
the
person/aivanov/vdk-quickstart
branch
from
ef5a2a0
to
a07c767
Compare
duyguHsnHsn
approved these changes
Mar 9, 2023
ivakoleva
pushed a commit
that referenced
this pull request
Mar 9, 2023
The use of global variables in GitLab CI can create problems when multiple CI files are being imported, as variables are not scoped to a specific file. This can lead to unexpected variables being set, causing issues in the CI/CD pipeline. This is what is happening wiht quickstart-vdk test - https://gitlab.com/vmware-analytics/versatile-data-kit/-/jobs/3901914540 It expected that there's python installed because it's supposed to use python image but some other file overrides this image to docker and causes the test to fail. This changes quickstart-vdk to use job-level variables. In future changes I will be changing all CIs to use job-level variables or environment variables to avoid conflicts and ensure proper scoping. Or ensure that global variabels and labels are prefixed with the project or plugin name. This is part of #1559 Testing Done: this PR CI Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of global variables in GitLab CI can create problems when multiple CI files are being imported, as variables are not scoped to a specific file. This can lead to unexpected variables being set, causing issues in the CI/CD pipeline.
This is what is happening wiht quickstart-vdk test - https://gitlab.com/vmware-analytics/versatile-data-kit/-/jobs/3901914540
It expected that there's python installed because it's supposed to use python image but some other file overrides this image to docker and causes the test to fail.
This changes quickstart-vdk to use job-level variables.
In future changes I will be changing all CIs to use job-level variables or environment variables to avoid conflicts and ensure proper scoping. Or ensure that global variabels and labels are prefixed with the project or plugin name.
This is part of #1559
Testing Done: this PR CI