frontend: Fix shebang in build_shared.sh #1743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivakoleva
approved these changes
Mar 14, 2023
There was a problem hiding this comment.
LGTM; Are you also considering adding some additional messaging to enable us troubleshooting https://gitlab.com/vmware-analytics/versatile-data-kit/-/jobs/3927259840? Is that one-time only, or reoccurring event?
(nit: may look in k8s cicd namespace to find any traces of runner pods execution)
duyguHsnHsn
approved these changes
Mar 14, 2023
DeltaMichael
force-pushed
the
person/mdilyan/fix-shebang
branch
from
9c4a95e
to
67c7256
Compare
DeltaMichael
force-pushed
the
person/mdilyan/fix-shebang
branch
2 times, most recently
from
fdfc3d8
to
c46b066
Compare
Change shebang in build_shared.sh to !/bin/bash -e This points to the correct execution shell for build scripts and passes the -e flag, which makes the script fail on the forst error exit code Signed-off-by: Dilyan Marinov <mdilyan@vmware.com>
DeltaMichael
force-pushed
the
person/mdilyan/fix-shebang
branch
from
c46b066
to
c2aac0a
Compare
|
Also added the |
ivakoleva
pushed a commit
that referenced
this pull request
Mar 16, 2023
Change shebang in build_shared.sh to !/bin/bash -e This points to the correct execution shell for build scripts and passes the -e flag, which makes the script fail on the first error exit code Signed-off-by: Dilyan Marinov <mdilyan@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change shebang in build_shared.sh to !/bin/bash -e
This points to the correct execution shell for build scripts and passes the -e flag, which makes the script fail on the first error exit code