vdk-ipython: add finalize job #1744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duyguHsnHsn
force-pushed
the
person/hduygu/vdk-ipython-finalize-job
branch
from
c80b2f6
to
b48f537
Compare
antoniivanov
approved these changes
Mar 16, 2023
gageorgiev
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Added finalise_job for JobControl object which finalises the job instance in JobControl.
The job can be finalised manually or when exiting the iPython shell.
Why: A way to finalise the initialized job in ipython should be provided.
Tests: pytest test
Signed-off-by: Duygu Hasan hduygu@vmware.com