control-service: Only CLI executions are "Manual" #1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lled as "Manual" Currently, all executions started through the Execution API are labelled as "Manual". This makes it confusing in cases where users use the Execution API for starting executions not through the CLI, for example through the Airflow integration or by a Meta Job - users will still see the execution as "Manual" in the UI. This change ensures that only executions which were ran through the VDK CLI are labelled as "Manual". Further work is required for extracting and globalizing the "vdk-control-cli" string as it currently appears as a magic string in both the vdk-control-cli and the control-service. Testing done: ran data job through meta job and verified its label Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
…m:vmware/versatile-data-kit into person/gageorgiev/metajob-scheduled-label Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
...s_control_service/src/main/java/com/vmware/taurus/service/execution/JobExecutionService.java
Show resolved
Hide resolved
Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
…m:vmware/versatile-data-kit into person/gageorgiev/metajob-scheduled-label
…m:vmware/versatile-data-kit into person/gageorgiev/metajob-scheduled-label Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
...s_control_service/src/main/java/com/vmware/taurus/service/execution/JobExecutionService.java
Show resolved
Hide resolved
Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
…m:vmware/versatile-data-kit into person/gageorgiev/metajob-scheduled-label
…m:vmware/versatile-data-kit into person/gageorgiev/metajob-scheduled-label Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
…m:vmware/versatile-data-kit into person/gageorgiev/metajob-scheduled-label
Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
antoniivanov
approved these changes
Apr 24, 2023
…lled as "Manual" Currently, all executions started through the Execution API are labelled as "Manual". This makes it confusing in cases where users use the Execution API for starting executions not through the CLI, for example through the Airflow integration or by a Meta Job - users will still see the execution as "Manual" in the UI. This change ensures that only executions which were ran through the VDK CLI are labelled as "Manual". Further work is required for extracting and globalizing the "vdk-control-cli" string as it currently appears as a magic string in both the vdk-control-cli and the control-service. Testing done: ran data job through meta job and verified its label Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
…on/gageorgiev/metajob-scheduled-label
…m:vmware/versatile-data-kit into person/gageorgiev/metajob-scheduled-label Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, all executions started through the Execution API are labelled
as "Manual". This makes it confusing in cases where users use the Execution
API for starting executions not through the CLI, for example through the
Airflow integration or by a Meta Job - users will still see the execution
as "Manual" in the UI.
This change ensures that only executions which were ran through the
VDK CLI are labelled as "Manual". Further work is required for
extracting and globalizing the "vdk-control-cli" string as it
currently appears as a magic string in both the vdk-control-cli
and the control-service.
Testing done: ran data job through meta job and verified its label
Signed-off-by: Gabriel Georgiev gageorgiev@vmware.com