control-service: protect against v1 cron batch not being supported #1777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…luster Signed-off-by: murphp15 <murphp15@tcd.ie>
murphp15
requested review from
doks5,
antoniivanov,
ivakoleva and
DeltaMichael
and removed request for
doks5 and
antoniivanov
doks5
approved these changes
Mar 23, 2023
ivakoleva
approved these changes
Mar 23, 2023
...cts/pipelines_control_service/src/main/java/com/vmware/taurus/service/KubernetesService.java
Show resolved
Hide resolved
...cts/pipelines_control_service/src/main/java/com/vmware/taurus/service/KubernetesService.java
Show resolved
Hide resolved
DeltaMichael
approved these changes
Mar 23, 2023
|
@ivakoleva |
antoniivanov
approved these changes
Mar 23, 2023
murphp15
deleted the
person/murphp15/protect_against_v1_cron_batch_not_being_supported
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
When we merged this PR https://github.com/vmware/versatile-data-kit/pull/1580/files we unintentionally broke compatibility with version 1.19 and 1.20.
We always check for v1 versions of batch jobs. checking for that version on clusters <1.21 will result in errors.
What
Within this PR we add a guard around that statement and swallow the error if it happens.
How has this been tested
installed old version of k8s locally and ran integration tests against it.
Within the class DataJobDeploymentCrudIT I also changed the property
atajobs.control.k8s.k8sSupportsV1CronJobtofalse. As this is the config that should be set for 1.20.All tests are green.
I also ran the integration tests on main against the old cluster to make sure it catches the bug and it does result in many failed tests.
Not handled in this PR
How do we prevent issues like this in the future?
Maybe integration tests run against many versions of k8s?