Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/control-service: update contributor documentation #1779

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

DeltaMichael
Copy link
Contributor

@DeltaMichael DeltaMichael commented Mar 23, 2023

Why?

Contributor doc for control-service is inaccurate and hard to use

What?

Restructure document so how-to-run sections are at the beginning Update running locally section with correct instructions

How has this been tested?

Ran the service locally using updated instructions

What type of change are you making?

Documentation change, non-breaking

Follow-up tickets

#1780

Why?

Contributor doc for control-service is inaccurate and hard to use

What?

Restructure document so how-to-run sections are at the beginning
Update running locally section with correct instructions

How has this been tested?

Ran the service locally using updated instructions

What type of change are you making?

Documentation change, non-breaking

Signed-off-by: Dilyan Marinov <mdilyan@vmware.com>
Copy link
Collaborator

@antoniivanov antoniivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@antoniivanov
Copy link
Collaborator

If there's a ticket issue, please link it.

@DeltaMichael DeltaMichael merged commit 3942963 into main Mar 24, 2023
@DeltaMichael DeltaMichael deleted the person/mdilyan/control-service-docs branch March 24, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants