Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdk-plugins: add connection hook activity diagram #1786

Merged
merged 5 commits into from
Mar 30, 2023

Conversation

antoniivanov
Copy link
Collaborator

I was playing around (learning how to write PlantUML activity diagrams) and wrote one about how PEP 249 operations and conneciton hooks work.

In my opinion, a picture is worth a thousand words and the current documentation for connection hooks is a bit too text-heavy without showing enough.

I think this would improve understandability of how connection hooks work

I was playing around (learning how to write PlantUML activity diagrams)
and wrote one about how PEP 249 operations and conneciton hooks work.

In my opinion, a picture is worth a thousand words and the current
documentation for connection hooks is a bit too text-heavy without
showing enough.

I think this would improve understandabilty of how connection hooks work

Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
@antoniivanov
Copy link
Collaborator Author

Hint: to review easier markdowns click
image

Copy link
Contributor

@ivakoleva ivakoleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

projects/vdk-plugins/README.md Outdated Show resolved Hide resolved
projects/vdk-plugins/README.md Show resolved Hide resolved
@antoniivanov antoniivanov enabled auto-merge (squash) March 29, 2023 14:31
@antoniivanov antoniivanov enabled auto-merge (squash) March 29, 2023 18:09
@antoniivanov antoniivanov merged commit 8246b51 into main Mar 30, 2023
@antoniivanov antoniivanov deleted the person/aivanov/vdk-plugin-diagram branch March 30, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants