frontend: add build.sh #1807
Merged
frontend: add build.sh #1807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivakoleva
approved these changes
Mar 31, 2023
As outlined here - https://github.com/vmware/versatile-data-kit/blob/main/cicd/build.sh#L40 - the top level projects are supposed to have build.sh that fully builds the project or provides intructions Adding build.sh for frontend Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
antoniivanov
force-pushed
the
person/aivanov/frontend
branch
from
c8fa70f
to
9fd9ade
Compare
|
should we test-cover the build.sh requirement and operability |
We can rely on install_data_pipelines.sh and install_shared.sh are run in CI pipeline. This is primarily useful for someone for a first time building the project locally. |
murphp15
approved these changes
Mar 31, 2023
gorankokin
approved these changes
Mar 31, 2023
yonitoo
pushed a commit
that referenced
this pull request
Apr 4, 2023
As outlined here - https://github.com/vmware/versatile-data-kit/blob/main/cicd/build.sh#L40 the top level projects are supposed to have build.sh that fully builds the project or provides intructions Adding build.sh for frontend Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined here -
https://github.com/vmware/versatile-data-kit/blob/main/cicd/build.sh#L40
the top level projects are supposed to have build.sh that fully builds the project or provides intructions
Adding build.sh for frontend