frontend: Align code formatting in frontend projects #1863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gorankokin
added
the
area/frontend
ivakoleva
approved these changes
Apr 10, 2023
...es/gui/projects/data-pipelines/src/lib/components/base-grid/data-jobs-base-grid.component.ts
Show resolved
Hide resolved
...ponents/data-job/pages/executions/execution-status-chart/execution-status-chart.component.ts
Show resolved
Hide resolved
DeltaMichael
approved these changes
Apr 10, 2023
Aligned formatting in shared and data-pipelines frontend using same configuration for prettier and .editorconfig Executed auto format on project data-pipelines. No regression are expected, because only formatting is committed. Tested local builds, linking built lib to UI and manual validatino on every screen, and seems there is no problems. ESLint executed successfully and there no issues. --------- Signed-off-by: gorankokin <gorankokin@gmail.com>
for more information, see https://pre-commit.ci
gorankokin
force-pushed
the
person/gorankokin/align-formatting-frontend-projects-1801
branch
from
5053f04
to
e34fa21
Compare
gorankokin
deleted the
person/gorankokin/align-formatting-frontend-projects-1801
branch
mivanov1988
pushed a commit
that referenced
this pull request
Apr 13, 2023
Aligned formatting in shared and data-pipelines frontend using same configuration for prettier and .editorconfig Executed auto format on project data-pipelines. No regression are expected, because only formatting is committed. Tested local builds, linking built lib to UI and manual validatino on every screen, and seems there is no problems. ESLint executed successfully and there no issues. Addressing issue #1801 --------- Signed-off-by: gorankokin <gorankokin@gmail.com> --------- Signed-off-by: gorankokin <gorankokin@gmail.com> Co-authored-by: Goran Kokinovski <gkokinovski@vmware.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligned formatting in shared and data-pipelines frontend using same configuration for prettier and .editorconfig Executed auto format on project data-pipelines.
No regression are expected, because only formatting is committed.
Tested local builds, linking built lib to UI and manual validatino on every screen, and seems there is no problems. ESLint executed successfully and there no issues.
Addressing issue #1801
Signed-off-by: gorankokin gorankokin@gmail.com