frontend: publish docker image for ui #1872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeltaMichael
force-pushed
the
person/mdilyan/fe-gitlab-docker-publish
branch
from
597a355
to
8ffd1f1
Compare
ivakoleva
reviewed
Apr 11, 2023
DeltaMichael
force-pushed
the
person/mdilyan/fe-gitlab-docker-publish
branch
from
8ffd1f1
to
df8927a
Compare
murphp15
reviewed
Apr 12, 2023
murphp15
reviewed
Apr 12, 2023
murphp15
approved these changes
Apr 12, 2023
ivakoleva
approved these changes
Apr 19, 2023
DeltaMichael
force-pushed
the
person/mdilyan/fe-gitlab-docker-publish
branch
2 times, most recently
from
9c06830
to
70a2698
Compare
DeltaMichael
changed the title
DeltaMichael
force-pushed
the
person/mdilyan/fe-gitlab-docker-publish
branch
7 times, most recently
from
d0c12d2
to
f837f04
Compare
added 2 commits
April 20, 2023 17:54
Why? Part of the wider effort to add the ui to quickstart-vdk. The ui should be shippable as a docker image. What? Create dockerfile + nginx configuration for the ui The dockerfile spins up an nginx server on port 8091 and copies over the contents of dist/ui to the server's html dir How has this been tested? Tested locally by running docker build -t vdk-ui . docker run --name vdk-ui-container -d -p 8080:8091 vdk-ui and making sure that the ui is served on https://localhost:8080 What type of change are you making? Feature, non-breaking Signed-off-by: Dilyan Marinov <mdilyan@vmware.com>
Why? Part of the wider effort to add the ui to quickstart-vdk. The ui should be shippable as a docker image. What? Create dockerfile + nginx configuration for the ui The dockerfile spins up an nginx server on port 8091 and copies over the contents of dist/ui to the server's html dir How has this been tested? Tested locally by running docker build -t vdk-ui . docker run --name vdk-ui-container -d -p 8080:8091 vdk-ui and making sure that the ui is served on https://localhost:8080 What type of change are you making? Feature, non-breaking Signed-off-by: Dilyan Marinov <mdilyan@vmware.com>
DeltaMichael
force-pushed
the
person/mdilyan/fe-gitlab-docker-publish
branch
from
f837f04
to
d070d60
Compare
DeltaMichael
changed the title
Why? Part of the wider effort to add the UI to quickstart-vdk What? Build and publish a docker image for the UI as part of the release step in the CI/CD pipeline. Image tags follow the same versioning schema as the data-pipelines package in the npm registry How has this been tested? Ran the gitlab script locally https://gitlab.com/vmware-analytics/versatile-data-kit/-/jobs/4148986837 What type of change are you making? New feature (non-breaking change which adds functionality) Signed-off-by: Dilyan Marinov <mdilyan@vmware.com>
DeltaMichael
force-pushed
the
person/mdilyan/fe-gitlab-docker-publish
branch
from
d070d60
to
de46d92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Stacked on top of #1862
Why?
Part of the wider effort to add the UI to quickstart-vdk
What?
Build and publish a docker image for the UI as part
of the release step in the CI/CD pipeline. Image tags
follow the same versioning schema as the data-pipelines
package in the npm registry
How has this been tested?
Ran the gitlab script locally
https://gitlab.com/vmware-analytics/versatile-data-kit/-/jobs/4148986837
What type of change are you making?
New feature (non-breaking change which adds functionality)
Signed-off-by: Dilyan Marinov mdilyan@vmware.com