control-service: Add python_version to Execution API #1878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why As part of the initiative to add support for multiple Python versions, we need to extend the Execution API to return python_version for each individual execution. What Added job_python_version column to the data_job_execution table and job_python_version field to the all DTOs related to the Execution API. Test done Unit tests Signed-off-by: Miroslav Ivanov miroslavi@vmware.com
ivakoleva
approved these changes
Apr 12, 2023
.../db/migration/V20230410140000__add_column_job_python_version_to_data_job_execution_table.sql
Show resolved
Hide resolved
.../pipelines_control_service/src/main/java/com/vmware/taurus/datajobs/ToApiModelConverter.java
Show resolved
Hide resolved
...ipelines_control_service/src/main/java/com/vmware/taurus/service/model/DataJobExecution.java
Show resolved
Hide resolved
Thanks for the review, @ivakoleva! |
murphp15
approved these changes
Apr 12, 2023
mivanov1988
added a commit
that referenced
this pull request
Apr 13, 2023
This PR aims to address the following comment: #1878 (comment)
mivanov1988
deleted the
person/miroslavi/add-python-version-to-execution-api
branch
mivanov1988
added a commit
that referenced
this pull request
Apr 18, 2023
This PR aims to address the following comment: #1878 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
As part of the initiative to add support for multiple Python versions, we need to extend the Execution API to return python_version for each individual execution.
What
Added job_python_version column to the data_job_execution table and job_python_version field to all DTOs related to the Execution API.
Test done
Unit tests. IT test will be added later since the feature for adding support for multiple Python versions is not ready for e2e testing.
Signed-off-by: Miroslav Ivanov miroslavi@vmware.com