Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

control-service: add the frontend to helm #1885

Merged
merged 8 commits into from
Apr 18, 2023

Conversation

murphp15
Copy link
Collaborator

@murphp15 murphp15 commented Apr 12, 2023

What

Within the introduction of the frontend docker image we want it to appear when ppl visit the host url.

How

In this PR we introduce:

  1. a new deployment and service to support running the frontend.
  2. an ingress rule to send requests from the root of the host to the frontend and an ingress rule to send any requests for /data-jobs to the control-service.
  3. Support for reading the frontend docker image from a private repo which is something we need within VMWare.
  4. Update the control-service to the a newer version
  5. add support for basic configuration of the frontend service e.g. how much cpu the deployment is given.

What is not in this PR:

  1. passing configuration to the frontend via properties or volumeMounts.

How has this been tested

Locally

Signed-off-by: murphp15 <murphp15@tcd.ie>
@ivakoleva
Copy link
Contributor

Before this PR, if ingress was enabled the control-service was mapped to the root of the host url.
After this PR,

frontend-ui is mapped to the root of the host url.
control-service is mapped to /data-jobs

May you also elaborate on Swagger UI?

Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
@murphp15
Copy link
Collaborator Author

Before this PR, if ingress was enabled the control-service was mapped to the root of the host url.
After this PR,
frontend-ui is mapped to the root of the host url.
control-service is mapped to /data-jobs

May you also elaborate on Swagger UI?

@ivakoleva there is no impact on the swagger url as that starts with /data-jobs.
In fact no endpoint urls for the control-plane are changed so I am going to remove the breaking-change section from the description.

@murphp15 murphp15 enabled auto-merge (squash) April 18, 2023 09:35
@murphp15 murphp15 disabled auto-merge April 18, 2023 09:35
@murphp15 murphp15 enabled auto-merge (squash) April 18, 2023 09:36
@murphp15 murphp15 merged commit ff09cb0 into main Apr 18, 2023
4 of 5 checks passed
@murphp15 murphp15 deleted the person/murphp15/add_frontend_to_helm branch April 18, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants