vdk-jupyter: job run messages #1908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murphp15
approved these changes
Apr 18, 2023
ivakoleva
approved these changes
Apr 18, 2023
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/style/vdkDialogs.css
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/__tests__/resquests.spec.ts
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/components/VdkErrorMessage.ts
Show resolved
Hide resolved
ivakoleva
reviewed
Apr 18, 2023
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/vdk_jupyterlab_extension/vdk_ui.py
Show resolved
Hide resolved
yonitoo
approved these changes
Apr 18, 2023
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/components/VdkErrorMessage.ts
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/__tests__/show-dialog.spec.tsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
More informative and easy to understand Run message are introduced:
Here are some screenshots of the newly introduced dialogs:
Why:
Currently, when we run a Job from the VDK menu in Jupyter UI we get an alert with the execution status of the job.
If the users wants to see the actual error, he needs to checks the logs.
This might lead to user confusion and expects users to know that status 0 means success and anything else means error.
With the new implementation it is easier for the user to see the status of the run and the user should not check the logs to see what the error was.
Tests: jest tests
Signed-off-by: Duygu Hasan hduygu@vmware.com