frontend: Configurable OAuth #1913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OAuth config was priorly hardcoded in multiple files. We need to be able to produce an image, enabling OAuth configuration upon deployment. Introduced an appConfig.json asset, and a lean service to read the config upon initialization at first. Testing done: did `npm start` locally and verified that I successfully authenticate using CSP STG. TODO: need to fix the AppConfigService init for testing performed at the end of install_data_pipelines.sh: `npm run test:headless` Signed-off-by: ivakoleva <iva.koleva@clearcode.bg>
OAuth config was priorly hardcoded in multiple files. We need to be able to produce an image, enabling OAuth configuration upon deployment. Introduced an appConfig.json asset, and a lean service to read the config upon initialization at first. Testing done: ci/cd Signed-off-by: ivakoleva <iva.koleva@clearcode.bg>
OAuth config was priorly hardcoded in multiple files. We need to be able to produce an image, enabling OAuth configuration upon deployment. Introduced an appConfig.json asset, and a lean service to read the config upon initialization at first. Testing done: ci/cd Signed-off-by: ivakoleva <iva.koleva@clearcode.bg>
projects/frontend/data-pipelines/gui/projects/ui/src/app/app-config.service.ts
Outdated
Show resolved
Hide resolved
projects/frontend/data-pipelines/gui/projects/ui/src/app/app.module.ts
Outdated
Show resolved
Hide resolved
projects/frontend/data-pipelines/gui/projects/ui/src/app/app.module.ts
Outdated
Show resolved
Hide resolved
yonitoo
approved these changes
Apr 19, 2023
DeltaMichael
approved these changes
Apr 19, 2023
OAuth config was priorly hardcoded in multiple files. We need to be able to produce an image, enabling OAuth configuration upon deployment. Introduced an appConfig.json asset, and a lean service to read the config upon initialization at first. Testing done: ci/cd Signed-off-by: ivakoleva <iva.koleva@clearcode.bg>
OAuth config was priorly hardcoded in multiple files. We need to be able to produce an image, enabling OAuth configuration upon deployment. Introduced an appConfig.json asset, and a lean service to read the config upon initialization at first. Testing done: ci/cd Signed-off-by: ivakoleva <iva.koleva@clearcode.bg>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OAuth config was priorly hardcoded in multiple files. We need to be able to produce an image, enabling OAuth configuration upon deployment.
Introduced an appConfig.json asset, and a lean service to read the config upon initialization at first.
Testing done: ci/cd