vdk-server: Wire up external containers (Git, Docker) with the service #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vice Updated the Helm installation to account for the previously installed Git and Docker containers. This includes obtaining and passing the IP of the Git container directly because the Job Builder fails to resolve it. Reduced the number of replicas of the control service and the database to 1. Added missing dependencies to setup.py. Signed-off-by: Tsvetomir Palashki <tpalashki@vmware.com>
antoniivanov
reviewed
Sep 7, 2021
projects/vdk-core/plugins/vdk-server/src/taurus/vdk/installer.py
Outdated
Show resolved
Hide resolved
projects/vdk-core/plugins/vdk-server/src/taurus/vdk/installer.py
Outdated
Show resolved
Hide resolved
* Rename a local variable to avoid name shadowing * Properly call the Docker client's close method Signed-off-by: Tsvetomir Palashki <tpalashki@vmware.com>
antoniivanov
approved these changes
Sep 7, 2021
ivakoleva
pushed a commit
that referenced
this pull request
Sep 7, 2021
#194) * vdk-server: Wire up external containers (Git and Docker) with the service Updated the Helm installation to account for the previously installed Git and Docker containers. This includes obtaining and passing the IP of the Git container directly because the Job Builder fails to resolve it. Reduced the number of replicas of the control service and the database to 1. Added missing dependencies to setup.py. Signed-off-by: Tsvetomir Palashki <tpalashki@vmware.com> * vdk-server: improve the installer code * Rename a local variable to avoid name shadowing * Properly call the Docker client's close method Signed-off-by: Tsvetomir Palashki <tpalashki@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the Helm installation to account for the previously installed Git
and Docker containers. This includes obtaining and passing the IP of the
Git container directly because the Job Builder fails to resolve it.
Reduced the number of replicas of the control service and the database to 1.
Added missing dependencies to setup.py.
Signed-off-by: Tsvetomir Palashki tpalashki@vmware.com