control-service: [Bug fix] Fix supported python versions helm configuration #1964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ration A regression was introduced in the Control Service's helm chart when 54914a0 was merged, which caused Control Service installation failures. The error observed at `helm upgrade` command execution is ``` Error: UPGRADE FAILED: error validating "": error validating data: ValidationError(Deployment.spec.template.spec.containers[0].env[79].value): invalid type for io.k8s.api.core.v1.EnvVar.value: got "map", expected "string" ``` The error was raised because the map was not properly converted to string. This change fixes the error. Testing Done: Executed locally `helm install ...` against a kind cluster and verified that the environment variable was properly set. ``` DATAJOBS_DEPLOYMENT_DEFAULT_PYTHON_VERSION: 3.7 DATAJOBS_DEPLOYMENT_SUPPORTED_PYTHON_VERSIONS: {"3.7":{"baseImage":"registry.hub.docker.com/versatiledatakit/data-job-base-python-3.7:latest", "vdkImage":"registry.hub.docker.com/versatiledatakit/quickstart-vdk:release"}} ``` Signed-off-by: Andon Andonov <andonova@vmware.com>
mivanov1988
approved these changes
Apr 27, 2023
dakodakov
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression was introduced in the Control Service's helm chart when 54914a0 was merged, which caused Control Service installation failures. The error observed at
helm upgradecommand execution isThe error was raised because the map was not properly converted to string.
This change fixes the error.
Testing Done: Executed locally
helm install ...against a kind cluster and verified that the environment variable was properly set.