control-service: add ability to check if docker image exists in ecr #1977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
mivanov1988
reviewed
Apr 27, 2023
...es_control_service/src/main/java/com/vmware/taurus/service/deploy/DockerRegistryService.java
Outdated
Show resolved
Hide resolved
mivanov1988
reviewed
Apr 27, 2023
...e/src/integration-test/java/com/vmware/taurus/datajobs/it/TestJobDeployTemporaryCredsIT.java
Outdated
Show resolved
Hide resolved
mivanov1988
reviewed
Apr 27, 2023
...es_control_service/src/main/java/com/vmware/taurus/service/deploy/DockerRegistryService.java
Show resolved
Hide resolved
mivanov1988
reviewed
Apr 27, 2023
...es_control_service/src/main/java/com/vmware/taurus/service/deploy/DockerRegistryService.java
Outdated
Show resolved
Hide resolved
...es_control_service/src/main/java/com/vmware/taurus/service/deploy/DockerRegistryService.java
Outdated
Show resolved
Hide resolved
...es_control_service/src/main/java/com/vmware/taurus/service/deploy/DockerRegistryService.java
Outdated
Show resolved
Hide resolved
...es_control_service/src/main/java/com/vmware/taurus/service/deploy/DockerRegistryService.java
Outdated
Show resolved
Hide resolved
...es_control_service/src/main/java/com/vmware/taurus/service/deploy/DockerRegistryService.java
Outdated
Show resolved
Hide resolved
...es_control_service/src/main/java/com/vmware/taurus/service/deploy/DockerRegistryService.java
Outdated
Show resolved
Hide resolved
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
mivanov1988
reviewed
May 15, 2023
...e/src/integration-test/java/com/vmware/taurus/datajobs/it/TestJobDeployTemporaryCredsIT.java
Outdated
Show resolved
Hide resolved
...e/src/integration-test/java/com/vmware/taurus/datajobs/it/TestJobDeployTemporaryCredsIT.java
Outdated
Show resolved
Hide resolved
...e/src/integration-test/java/com/vmware/taurus/datajobs/it/TestJobDeployTemporaryCredsIT.java
Outdated
Show resolved
Hide resolved
...e/src/integration-test/java/com/vmware/taurus/datajobs/it/TestJobDeployTemporaryCredsIT.java
Show resolved
Hide resolved
...e/src/integration-test/java/com/vmware/taurus/datajobs/it/TestJobDeployTemporaryCredsIT.java
Outdated
Show resolved
Hide resolved
ivakoleva
approved these changes
May 15, 2023
...e/src/integration-test/java/com/vmware/taurus/datajobs/it/TestJobDeployTemporaryCredsIT.java
Outdated
Show resolved
Hide resolved
...e/src/integration-test/java/com/vmware/taurus/datajobs/it/TestJobDeployTemporaryCredsIT.java
Outdated
Show resolved
Hide resolved
...e/src/integration-test/java/com/vmware/taurus/datajobs/it/TestJobDeployTemporaryCredsIT.java
Outdated
Show resolved
Hide resolved
...e/src/integration-test/java/com/vmware/taurus/datajobs/it/TestJobDeployTemporaryCredsIT.java
Show resolved
Hide resolved
...e/src/integration-test/java/com/vmware/taurus/datajobs/it/TestJobDeployTemporaryCredsIT.java
Outdated
Show resolved
Hide resolved
...nes_control_service/src/main/java/com/vmware/taurus/service/deploy/EcrRegistryInterface.java
Outdated
Show resolved
Hide resolved
...nes_control_service/src/main/java/com/vmware/taurus/service/deploy/EcrRegistryInterface.java
Outdated
Show resolved
Hide resolved
...nes_control_service/src/main/java/com/vmware/taurus/service/deploy/EcrRegistryInterface.java
Outdated
Show resolved
Hide resolved
...nes_control_service/src/main/java/com/vmware/taurus/service/deploy/EcrRegistryInterface.java
Show resolved
Hide resolved
...nes_control_service/src/main/java/com/vmware/taurus/service/deploy/EcrRegistryInterface.java
Outdated
Show resolved
Hide resolved
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
mivanov1988
approved these changes
May 16, 2023
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what: added functionality in the DockerRegistryService class which checks if the data job image exists in a ECR style repository. This functionality was previously unimplemented. Adopted the latest version of the job builder - 1.3.3, which can handle creating images with temporary amazon credentials too to be used in the integration tests.
why: as a control-service user needed to migrate to a different repository we noticed that this functionality was missing, had it been present the migration could have been quicker.
testing: modified existing integration test to utilize the new method while checking if image is created in the database. New method is also covered by the modified integration test since, it's called within the build image method.